From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S265291AbUHMNnN (ORCPT ); Fri, 13 Aug 2004 09:43:13 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S265285AbUHMNnN (ORCPT ); Fri, 13 Aug 2004 09:43:13 -0400 Received: from ozlabs.org ([203.10.76.45]:215 "EHLO ozlabs.org") by vger.kernel.org with ESMTP id S265291AbUHMNnG (ORCPT ); Fri, 13 Aug 2004 09:43:06 -0400 Subject: Re: module.viomap support for ppc64 From: Rusty Russell To: Olaf Hering Cc: Hollis Blanchard , Dave Boutcher , linuxppc64-dev@lists.linuxppc.org, lkml - Kernel Mailing List In-Reply-To: <20040813094040.GA1769@suse.de> References: <20040812173751.GA30564@suse.de> <1092339278.19137.8.camel@localhost> <1092354195.25196.11.camel@bach> <20040813094040.GA1769@suse.de> Content-Type: text/plain Message-Id: <1092404570.29604.5.camel@bach> Mime-Version: 1.0 X-Mailer: Ximian Evolution 1.4.6 Date: Fri, 13 Aug 2004 23:42:50 +1000 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2004-08-13 at 19:40, Olaf Hering wrote: > On Fri, Aug 13, Rusty Russell wrote: > > > 2) Please modify scripts/mod/file2alias.c in the kernel source, not the > > module tools. The modules.XXXmap files are deprecated: device tables > > are supposed to be converted to aliases in the build process, and that > > is how userspace tools like hotplug are to find them. > > I found no user of the modules.alias file. Hotplug still uses the map > files. Parsing one big file will not improve performance, but thats a > different story. You don't use the modules.alias file. You simply "modprobe vio:xyz^abc" and modprobe reads modules.alias if necessary (the user can also insert aliases in the modprobe.conf file, for example). Note that fnmatch is used, so you can actually use ? and * in your generated aliases. > A hack for 2.6.8-rc4 is below. Can I read the alias file via > while read a b c ; do : done < modules.alias ? > Is b supposed to contain not spaces? What special delimiter chars are > allowed? The 'name' and 'compat' property can contain almost any char. > I used '^' for the time being. Spaces are probably a bad idea, yes. ^ is a little odd, but probably not a bad choice. You could even use a full: "vio:name:%s:compat:%s" if you wanted to. > > 3) I will still accept patches to module-init-tools if required for 2.4 > > compatibility, but they will be going away at some point! > > Noone cares about that old junk. Shh... Marcelo might get offended 8) Patch looks fine... Rusty. -- Anyone who quotes me in their signature is an idiot -- Rusty Russell