From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: maximilian attems <janitor@sternwelten.at>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
kj <kernel-janitors@osdl.org>
Subject: Re: Add msleep_interruptible() function to kernel/timer.c
Date: Sun, 15 Aug 2004 12:54:52 +0100 [thread overview]
Message-ID: <1092570891.17605.1.camel@localhost.localdomain> (raw)
In-Reply-To: <20040815121805.GA15111@stro.at>
On Sul, 2004-08-15 at 13:18, maximilian attems wrote:
> + * msleep_interruptible - sleep waiting for waitqueue interruptions
> + * @msecs: Time in milliseconds to sleep for
> + */
> +void msleep_interruptible(unsigned int msecs)
> +{
> + unsigned long timeout = msecs_to_jiffies(msecs);
> +
> + while (timeout) {
You want to have while(timeout && !signal_pending(current))
A signal will wake the timeout which will then loop. It might also
be good to add
> + set_current_state(TASK_INTERRUPTIBLE);
> + timeout = schedule_timeout(timeout);
> + }
return timeout;
so that the caller knows more about how long the timer ran for before
the interrupt and if it was interrupted.
next prev parent reply other threads:[~2004-08-15 12:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-15 12:18 Add msleep_interruptible() function to kernel/timer.c maximilian attems
2004-08-15 11:54 ` Alan Cox [this message]
2004-08-15 13:25 ` maximilian attems
2004-08-16 2:22 ` Ingo Molnar
2004-08-16 20:00 ` [Kernel-janitors] " Nishanth Aravamudan
2004-08-15 12:50 ` Oliver Neukum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1092570891.17605.1.camel@localhost.localdomain \
--to=alan@lxorguk.ukuu.org.uk \
--cc=janitor@sternwelten.at \
--cc=kernel-janitors@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox