From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S266157AbUHRMZi (ORCPT ); Wed, 18 Aug 2004 08:25:38 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S266186AbUHRMZM (ORCPT ); Wed, 18 Aug 2004 08:25:12 -0400 Received: from pD951734E.dip.t-dialin.net ([217.81.115.78]:44934 "EHLO undata.org") by vger.kernel.org with ESMTP id S266157AbUHRMX3 (ORCPT ); Wed, 18 Aug 2004 08:23:29 -0400 Subject: Re: [patch] voluntary-preempt-2.6.8.1-P1 From: Thomas Charbonnel To: Ingo Molnar Cc: Lee Revell , Florian Schmidt , linux-kernel , Felipe Alfaro Solana In-Reply-To: <20040817081829.GA1977@elte.hu> References: <1092624221.867.118.camel@krustophenia.net> <20040816032806.GA11750@elte.hu> <20040816033623.GA12157@elte.hu> <1092627691.867.150.camel@krustophenia.net> <20040816034618.GA13063@elte.hu> <1092628493.810.3.camel@krustophenia.net> <20040816040515.GA13665@elte.hu> <20040817021431.169d07db@mango.fruits.de> <1092701223.13981.106.camel@krustophenia.net> <20040817073927.GA594@elte.hu> <20040817081829.GA1977@elte.hu> Content-Type: text/plain Message-Id: <1092831729.5777.162.camel@localhost> Mime-Version: 1.0 X-Mailer: Ximian Evolution 1.4.6 Date: Wed, 18 Aug 2004 14:22:09 +0200 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Ingo Molnar wrote : > * Ingo Molnar wrote: > > > > Yes, Ingo identified an issue with copy_page_range, I don't think it's > > > fixed yet. See the voluntary-preempt-2.6.8.1-P0 thread. > > > > right, it's not fixed yet. It's not a trivial critical section - we > > are holding two locks and are mapping two atomic kmaps. > > fortunately it's easier than i thought - neither the source pmd nor the > target pmd can go away so we can simply drop the locks, reschedule, and > remap. Does the patch below (ontop of -P3) fix the copy_page_range() > latencies you are seeing? > > Ingo > Ooops, sorry about my previous post, I had missed this one. It fixes the problem, thanks. Thomas