Re: [patch] enums to clear suspend-state confusion

Pavel Machek
2004-08-16T20:24:44Z

Hi!

> > This patch should clear up some confusion between driver model and
> > drivers people, and also prepares way to add runtime power managment
> > later. Please apply,

> > --- linux-mm/include/linux/pci.h 2004-07-28 22:43:31.000000000 +0200
> > +++ linux-delme/include/linux/pci.h 2004-08-12 13:41:12.000000000 +0200
> > @@ -637,7 +637,7 @@
> > const struct pci_device_id *id_table; /* must be non-NULL for probe to be called */
> > int (*probe) (struct pci_dev *dev, const struct pci_device_id *id); /* New device inserted */
> > void (*remove) (struct pci_dev *dev); /* Device removed (NULL if not a hot-plug capable driver) */
> > - int (*suspend) (struct pci_dev *dev, u32 state); /* Device suspended */
> > + int (*suspend) (struct pci_dev *dev, suspend_state_t reason); /* Device suspended */
>
> Does this mean that each driver needs rewrite of suspend callback?

Yes, all drivers will eventually have to be touched. Thats unavoidable.
Fortunately most drivers ignore state, and those that don't are saved
by suspend_state_t being u32 for now... so we
are not breaking them just now.

Pavel
--
64 bytes from 195.113.31.123: icmp_seq=28 ttl=51 time=448769.1 ms