From: Len Brown <len.brown@intel.com>
To: Bjorn Helgaas <bjorn.helgaas@hp.com>
Cc: Shawn Starr <shawn.starr@rogers.com>,
linux-kernel@vger.kernel.org,
Cyrille Ch?p?lov <cyrille@chepelov.org>
Subject: Re: 2.6.8.1-mm1 broke USB driver with ACPI pci irq routing... info follows
Date: 19 Aug 2004 02:38:25 -0400 [thread overview]
Message-ID: <1092897504.25902.220.camel@dhcppc4> (raw)
In-Reply-To: <566B962EB122634D86E6EE29E83DD808182C37A2@hdsmsx403.hd.intel.com>
On Wed, 2004-08-18 at 19:40, Bjorn Helgaas wrote:
> Make acpi_irq_penalty non-initdata, since it's used by the
> non_init acpi_pci_link_allocate().
hmmm, now that we need to keep this around, we might consider squeezing
it down to, say 64 bytes. This stuff will probably never run for IRQs >
64 and probably a byte/level is enough.
> And make acpi_irq_penalty_init()
> __init, since it is used only by the __init pci_acpi_init().
>
> Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
I'll apply this Bjorn.
I have to complement you on your paranoia to
1. keep acpi_pci_irq_enable(dev) for all devices in 2.6.8
2. add pci=routeirq to diagnose the breakage when you took it out
thanks,
-Len
next parent reply other threads:[~2004-08-19 6:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <566B962EB122634D86E6EE29E83DD808182C37A2@hdsmsx403.hd.intel.com>
2004-08-19 6:38 ` Len Brown [this message]
2004-08-17 6:57 2.6.8.1-mm1 broke USB driver with ACPI pci irq routing... info follows Shawn Starr
2004-08-17 14:48 ` Bjorn Helgaas
2004-08-18 1:04 ` Shawn Starr
2004-08-18 23:40 ` Bjorn Helgaas
2004-08-19 1:43 ` Shawn Starr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1092897504.25902.220.camel@dhcppc4 \
--to=len.brown@intel.com \
--cc=bjorn.helgaas@hp.com \
--cc=cyrille@chepelov.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shawn.starr@rogers.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox