From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Vincent Hanquez <tab@snarc.org>
Cc: lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ppc32 use simplified mmenonics
Date: Sun, 22 Aug 2004 12:00:49 +1000 [thread overview]
Message-ID: <1093140048.10506.277.camel@gaston> (raw)
In-Reply-To: <20040821222318.GA32229@snarc.org>
On Sun, 2004-08-22 at 08:23, Vincent Hanquez wrote:
> Hi LKML and Benjamin,
>
> This patch substitutes complex rlwinm instruction to the simplied
> instruction clrrwi when possible.
>
> This has the same meaning as the ppc knows only about rlwinm; clrrwi
> is just a language simplification.
>
> basicly it's a : s/rlwinm R1,R2,0,0,31-N/clrrwi R1,R2,N/
Oh well.. I've got quite used to tweaking rlwinm directly but I suppose
it's more clear for others to go to clrrwi. I see no obvious problem
though I haven't double checked the bit counts, I suppose you got the
substraction right everywhere but you know... it's always on the trivial
things that we make the nasty mistakes ;)
I'll look again when I'm back (I'm away for the week-end)
Ben.
next prev parent reply other threads:[~2004-08-22 2:11 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-21 22:23 [PATCH] ppc32 use simplified mmenonics Vincent Hanquez
2004-08-22 2:00 ` Benjamin Herrenschmidt [this message]
2004-08-22 9:48 ` Vincent Hanquez
-- strict thread matches above, loose matches on Subject: below --
2004-08-22 0:45 Albert Cahalan
2004-08-22 9:43 ` Vincent Hanquez
2004-08-22 10:41 ` Albert Cahalan
2004-08-22 14:45 ` Vincent Hanquez
2004-08-22 12:40 ` Albert Cahalan
2004-08-22 16:28 ` Vincent Hanquez
2004-08-22 14:29 ` Albert Cahalan
2004-08-22 19:17 ` Vincent Hanquez
2004-08-22 17:02 ` Horst von Brand
2004-08-23 1:24 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1093140048.10506.277.camel@gaston \
--to=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tab@snarc.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox