From: Rusty Russell <rusty@rustcorp.com.au>
To: Zwane Mwaikambo <zwane@fsmlabs.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>,
Nathan Lynch <nathanl@austin.ibm.com>,
Srivatsa Vaddagiri <vatsa@in.ibm.com>
Subject: Re: [PATCH][2.6] Hotplug cpu: Fix APIC queued timer vector race
Date: Sun, 22 Aug 2004 13:32:13 +1000 [thread overview]
Message-ID: <1093145533.4888.106.camel@bach> (raw)
In-Reply-To: <Pine.LNX.4.58.0408210923570.27390@montezuma.fsmlabs.com>
On Sun, 2004-08-22 at 00:10, Zwane Mwaikambo wrote:
> Some timer interrupt vectors were queued on the Local APIC and were being
> serviced when we enabled interrupts again in fixup_irqs(), so we need to
> mask the APIC timer, enable interrupts so that any queued interrupts get
> processed whilst the processor is still on the online map and then clear
> ourselves from the online map. 1ms is a nice safe number even under heavy
> interrupt load with higher priority vectors queued. Andrew this is
> the patch i promised, Rusty, i'm not sure if you find
> __attribute__((weak)) offensive...
It's horrible. Please move the unsetting of the cpu_online bit into the
arch-specific __cpu_disable() code for each arch, which is consistent
and also simplifies things.
Thanks,
Rusty.
--
Anyone who quotes me in their signature is an idiot -- Rusty Russell
next prev parent reply other threads:[~2004-08-22 3:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-21 14:10 [PATCH][2.6] Hotplug cpu: Fix APIC queued timer vector race Zwane Mwaikambo
2004-08-22 3:32 ` Rusty Russell [this message]
2004-08-22 14:47 ` Zwane Mwaikambo
2004-08-22 15:00 ` Zwane Mwaikambo
2004-08-23 1:16 ` Rusty Russell
2004-08-23 8:41 ` [PATCH] Hotplug cpu: Fix APIC queued timer vector race #2 Zwane Mwaikambo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1093145533.4888.106.camel@bach \
--to=rusty@rustcorp.com.au \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nathanl@austin.ibm.com \
--cc=vatsa@in.ibm.com \
--cc=zwane@fsmlabs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox