From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S265900AbUHVDcf (ORCPT ); Sat, 21 Aug 2004 23:32:35 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S265910AbUHVDce (ORCPT ); Sat, 21 Aug 2004 23:32:34 -0400 Received: from ozlabs.org ([203.10.76.45]:55470 "EHLO ozlabs.org") by vger.kernel.org with ESMTP id S265900AbUHVDcd (ORCPT ); Sat, 21 Aug 2004 23:32:33 -0400 Subject: Re: [PATCH][2.6] Hotplug cpu: Fix APIC queued timer vector race From: Rusty Russell To: Zwane Mwaikambo Cc: Linux Kernel , Andrew Morton , Nathan Lynch , Srivatsa Vaddagiri In-Reply-To: References: Content-Type: text/plain Message-Id: <1093145533.4888.106.camel@bach> Mime-Version: 1.0 X-Mailer: Ximian Evolution 1.4.6 Date: Sun, 22 Aug 2004 13:32:13 +1000 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2004-08-22 at 00:10, Zwane Mwaikambo wrote: > Some timer interrupt vectors were queued on the Local APIC and were being > serviced when we enabled interrupts again in fixup_irqs(), so we need to > mask the APIC timer, enable interrupts so that any queued interrupts get > processed whilst the processor is still on the online map and then clear > ourselves from the online map. 1ms is a nice safe number even under heavy > interrupt load with higher priority vectors queued. Andrew this is > the patch i promised, Rusty, i'm not sure if you find > __attribute__((weak)) offensive... It's horrible. Please move the unsetting of the cpu_online bit into the arch-specific __cpu_disable() code for each arch, which is consistent and also simplifies things. Thanks, Rusty. -- Anyone who quotes me in their signature is an idiot -- Rusty Russell