From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S268048AbUHVRYG (ORCPT ); Sun, 22 Aug 2004 13:24:06 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S268038AbUHVRX2 (ORCPT ); Sun, 22 Aug 2004 13:23:28 -0400 Received: from the-village.bc.nu ([81.2.110.252]:55439 "EHLO localhost.localdomain") by vger.kernel.org with ESMTP id S268040AbUHVRVW (ORCPT ); Sun, 22 Aug 2004 13:21:22 -0400 Subject: Re: PATCH: cdrecord: avoiding scsi device numbering for ide devices From: Alan Cox To: Christer Weinigel Cc: Pascal Schmidt , Linux Kernel Mailing List , Jens Axboe In-Reply-To: References: <2ptdY-42Y-55@gated-at.bofh.it> <2uPdM-380-11@gated-at.bofh.it> <2uUwL-6VP-11@gated-at.bofh.it> <2uWfh-8jo-29@gated-at.bofh.it> <2uXl0-Gt-27@gated-at.bofh.it> <2vge2-63k-15@gated-at.bofh.it> <2vgQF-6Ai-39@gated-at.bofh.it> <2vipq-7O8-15@gated-at.bofh.it> <2vj2b-8md-9@gated-at.bofh.it> <2vDtS-bq-19@gated-at.bofh.it> <412770EA.nail9DO11D18Y@burner> <412889FC.nail9MX1X3XW5@burner> Content-Type: text/plain Content-Transfer-Encoding: 7bit Message-Id: <1093191541.24759.1.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Ximian Evolution 1.4.6 (1.4.6-2) Date: Sun, 22 Aug 2004 17:19:11 +0100 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Sul, 2004-08-22 at 17:33, Christer Weinigel wrote: > /me keeping to the bad habit of following up to myself > > Regarding the current 2.6.8 kernel, wouldn't it be a better idea to > move the CAP_SYS_RAWIO check to open time instead of when the ioctl is > called? This would require a new flag somewhere in the file structure > I suppose, e.g. file->f_mode & FMODE_RAWIO. This leads to all sorts of bugs where descriptors owned by one process are given to another less priviledged one. In the networking world similar logic led to holes because rsh for example gave root opened fd's to users. Alan