From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Tomasz Torcz <zdzichu@irc.pl>, akpm@osdl.org
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: 2.6.8.1-mm4
Date: Mon, 23 Aug 2004 19:31:15 +0100 [thread overview]
Message-ID: <1093285874.29822.19.camel@localhost.localdomain> (raw)
In-Reply-To: <20040823182113.GA30882@irc.pl>
On Llu, 2004-08-23 at 19:21, Tomasz Torcz wrote:
> >- This kernel has an x86 patch which alters the copy_*_user() functions so
> > they will return -EFAULT on a fault rather than the number of bytes which
> > remain to be copied. This is a bit of an experiment, because this seems to
> > be the preferred API for those functions. It's a see-what-breaks thing.
> >
>
> Things appear to broke. Sometimes kernel starts to spit page allocation
> failures into log for few minutes, despite memory beeing available:
The kernel relies on copy_from_user returning the number of bytes copied
so no suprise there. In fact if it returns -EFAULT and you've not
reworked all the drivers (including out of kernel serial drivers in
particular) you get a security hole because you can move the buffer
pointers backwards.
Other code uses it to decide what object was passed for compatibility
too.
Alan
next prev parent reply other threads:[~2004-08-23 20:24 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-22 8:34 2.6.8.1-mm4 Andrew Morton
2004-08-22 14:20 ` 2.6.8.1-mm4 (strange behavior on dual Opteron w/ NUMA) R. J. Wysocki
2004-08-23 15:29 ` David Howells
2004-08-23 15:46 ` Randy.Dunlap
2004-08-23 18:27 ` Andrew Morton
2004-08-23 18:57 ` Randy.Dunlap
2004-08-23 2:18 ` 2.6.8.1-mm4 - failed opcode was: 0xe7 Ed Tomlinson
2004-08-23 5:00 ` 2.6.8.1-mm4 Eric W. Biederman
2004-08-23 12:00 ` 2.6.8.1-mm4 Alan Cox
2004-08-23 14:24 ` 2.6.8.1-mm4 Eric W. Biederman
2004-08-23 14:11 ` 2.6.8.1-mm4 (compile stats) John Cherry
2004-08-23 18:21 ` 2.6.8.1-mm4 Tomasz Torcz
2004-08-23 18:31 ` Alan Cox [this message]
2004-08-23 19:40 ` 2.6.8.1-mm4 Andrew Morton
2004-08-23 19:15 ` 2.6.8.1-mm4 Alan Cox
2004-08-23 21:19 ` 2.6.8.1-mm4 David S. Miller
2004-08-23 20:21 ` 2.6.8.1-mm4 wli
2004-08-24 6:14 ` 2.6.8.1-mm4 Andrew Morton
2004-08-24 7:55 ` O(1) proc_pid_statm() William Lee Irwin III
2004-08-24 17:05 ` fix text reporting in " William Lee Irwin III
2004-08-25 0:06 ` [PATCH] advice to use good patch subject, for SubmittingPatches Tim Bird
2004-08-23 22:18 ` 2.6.8.1-mm4 - more cpu hotplug breakage Nathan Lynch
2004-08-25 3:57 ` Nathan Lynch
2004-08-25 23:09 ` Nathan Lynch
2004-08-26 2:54 ` Rusty Russell
2004-08-26 7:57 ` [PATCH 1/2] Neaten migrate_all_tasks Rusty Russell
2004-08-26 7:58 ` [PATCH 2/2] Hotplug CPU vs TASK_ZOMBIEs: The Sequel to Hotplug CPU vs TASK_DEAD Rusty Russell
2004-08-26 15:29 ` Nathan Lynch
2004-08-27 1:38 ` Rusty Russell
2004-08-24 20:56 ` 2.6.8.1-mm4 William Lee Irwin III
2004-08-24 20:57 ` 2.6.8.1-mm4 William Lee Irwin III
2004-08-24 21:23 ` 2.6.8.1-mm4 William Lee Irwin III
2004-08-24 21:26 ` 2.6.8.1-mm4 William Lee Irwin III
2004-08-24 21:37 ` 2.6.8.1-mm4 William Lee Irwin III
2004-08-24 21:48 ` 2.6.8.1-mm4 William Lee Irwin III
2004-08-24 21:06 ` WAITQUEUE_DEBUG crapectomy William Lee Irwin III
-- strict thread matches above, loose matches on Subject: below --
2004-08-23 4:40 2.6.8.1-mm4 Sid Boyce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1093285874.29822.19.camel@localhost.localdomain \
--to=alan@lxorguk.ukuu.org.uk \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zdzichu@irc.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox