From: Thomas Duffy <Thomas.Duffy.99@alumni.brown.edu>
To: "Randy.Dunlap" <rddunlap@osdl.org>
Cc: bero@arklinux.org, lkml <linux-kernel@vger.kernel.org>,
akpm <akpm@osdl.org>,
ak@suse.de
Subject: Re: [PATCH] 2.6.8.1 modprobe tg3 oopses
Date: Mon, 23 Aug 2004 15:57:53 -0700 [thread overview]
Message-ID: <1093301873.7841.7.camel@duffman> (raw)
In-Reply-To: <20040821173654.6e5b9982.rddunlap@osdl.org>
[-- Attachment #1: Type: text/plain, Size: 1010 bytes --]
On Sat, 2004-08-21 at 17:36 -0700, Randy.Dunlap wrote:
> I wouldn't expect this to be compiler-dependent. There's an obvious
> problem with add_pin_to_irq(). It shouldn't be __init. Patch below.
> (I thought that I had already mailed this one time, but I don't
> see it anywhere.)
>
> arch/i386/kernel/io_apic.c | 2 +-
There also needs to be a similar patch for arch/x86_64/kernel/io_apic.c.
Doing this fixed the oops for me.
Thanks,
-tduffy
--- arch/x86_64/kernel/io_apic.c.orig 2004-08-23 15:28:16.574961000 -0700
+++ arch/x86_64/kernel/io_apic.c 2004-08-23 15:10:41.319960000 -0700
@@ -80,7 +80,7 @@
* shared ISA-space IRQs, so we have to support them. We are super
* fast in the common case, and fast for shared ISA-space IRQs.
*/
-static void __init add_pin_to_irq(unsigned int irq, int apic, int pin)
+static void add_pin_to_irq(unsigned int irq, int apic, int pin)
{
static int first_free_entry = NR_IRQS;
struct irq_pin_list *entry = irq_2_pin + irq;
z
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
prev parent reply other threads:[~2004-08-23 22:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20040820161141.28043ee8.rddunlap@osdl.org>
2004-08-22 0:36 ` [PATCH] 2.6.8.1 modprobe tg3 oopses Randy.Dunlap
2004-08-23 22:57 ` Thomas Duffy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1093301873.7841.7.camel@duffman \
--to=thomas.duffy.99@alumni.brown.edu \
--cc=ak@suse.de \
--cc=akpm@osdl.org \
--cc=bero@arklinux.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rddunlap@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox