* [PATCH] 2.6.8.1 modprobe tg3 oopses [not found] <20040820161141.28043ee8.rddunlap@osdl.org> @ 2004-08-22 0:36 ` Randy.Dunlap 2004-08-23 22:57 ` Thomas Duffy 0 siblings, 1 reply; 2+ messages in thread From: Randy.Dunlap @ 2004-08-22 0:36 UTC (permalink / raw) To: bero, Thomas.Duffy.99; +Cc: lkml, akpm | Subject: 2.6.8.1 "modprobe tg3" oopses with gcc 3.4.1 | | | I get this when trying to modprobe tg3 on an Acer Aspire 1500 notebook (32bit | mode) when the kernel [tried 2.6.8.1 and 2.6.8.1-mm1] is compiled with gcc | 3.4.1 (3.3.4 works): I wouldn't expect this to be compiler-dependent. There's an obvious problem with add_pin_to_irq(). It shouldn't be __init. Patch below. (I thought that I had already mailed this one time, but I don't see it anywhere.) | CPU: 0 | EIP: 0060:[<c03ba270>] Not tainted VLI | EFLAGS: 00210216 (2.6.8-1ark) | EIP is at add_pin_to_irq+0x0/0x60 <<<<< code is gone -- add_pin_to_irq() should not be __init; it is used after init code. Signed-off-by: Randy Dunlap <rddunlap@osdl.org> diffstat:= arch/i386/kernel/io_apic.c | 2 +- 1 files changed, 1 insertion(+), 1 deletion(-) diff -Naurp ./arch/i386/kernel/io_apic.c~ioapic_non_init ./arch/i386/kernel/io_apic.c --- ./arch/i386/kernel/io_apic.c~ioapic_non_init 2004-08-14 03:55:10.000000000 -0700 +++ ./arch/i386/kernel/io_apic.c 2004-08-21 17:26:52.695599728 -0700 @@ -85,7 +85,7 @@ int vector_irq[NR_VECTORS] = { [0 ... NR * shared ISA-space IRQs, so we have to support them. We are super * fast in the common case, and fast for shared ISA-space IRQs. */ -static void __init add_pin_to_irq(unsigned int irq, int apic, int pin) +static void add_pin_to_irq(unsigned int irq, int apic, int pin) { static int first_free_entry = NR_IRQS; struct irq_pin_list *entry = irq_2_pin + irq; ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] 2.6.8.1 modprobe tg3 oopses 2004-08-22 0:36 ` [PATCH] 2.6.8.1 modprobe tg3 oopses Randy.Dunlap @ 2004-08-23 22:57 ` Thomas Duffy 0 siblings, 0 replies; 2+ messages in thread From: Thomas Duffy @ 2004-08-23 22:57 UTC (permalink / raw) To: Randy.Dunlap; +Cc: bero, lkml, akpm, ak [-- Attachment #1: Type: text/plain, Size: 1010 bytes --] On Sat, 2004-08-21 at 17:36 -0700, Randy.Dunlap wrote: > I wouldn't expect this to be compiler-dependent. There's an obvious > problem with add_pin_to_irq(). It shouldn't be __init. Patch below. > (I thought that I had already mailed this one time, but I don't > see it anywhere.) > > arch/i386/kernel/io_apic.c | 2 +- There also needs to be a similar patch for arch/x86_64/kernel/io_apic.c. Doing this fixed the oops for me. Thanks, -tduffy --- arch/x86_64/kernel/io_apic.c.orig 2004-08-23 15:28:16.574961000 -0700 +++ arch/x86_64/kernel/io_apic.c 2004-08-23 15:10:41.319960000 -0700 @@ -80,7 +80,7 @@ * shared ISA-space IRQs, so we have to support them. We are super * fast in the common case, and fast for shared ISA-space IRQs. */ -static void __init add_pin_to_irq(unsigned int irq, int apic, int pin) +static void add_pin_to_irq(unsigned int irq, int apic, int pin) { static int first_free_entry = NR_IRQS; struct irq_pin_list *entry = irq_2_pin + irq; z [-- Attachment #2: This is a digitally signed message part --] [-- Type: application/pgp-signature, Size: 189 bytes --] ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2004-08-23 22:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20040820161141.28043ee8.rddunlap@osdl.org>
2004-08-22 0:36 ` [PATCH] 2.6.8.1 modprobe tg3 oopses Randy.Dunlap
2004-08-23 22:57 ` Thomas Duffy
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox