public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Thomas Duffy <Thomas.Duffy.99@alumni.brown.edu>
To: linux-kernel@vger.kernel.org
Cc: ak@suse.de
Subject: x86-64 compile error in 2.6.9-rc1-bk1
Date: Wed, 25 Aug 2004 11:54:54 -0700	[thread overview]
Message-ID: <1093460094.23633.18.camel@duffman> (raw)

[-- Attachment #1: Type: text/plain, Size: 1387 bytes --]

If you have CONFIG_SWIOTLB=y (GART_IOMMU=y), you get:

ld: BFD 2.15.90.0.3 20040415 assertion fail ../../bfd/linker.c:619
arch/x86_64/mm/built-in.o(.init.text+0x52a): In function `mem_init':
: undefined reference to `swiotlb_force'
make[1]: *** [.tmp_vmlinux1] Error 1
make: *** [_all] Error 2

This was added in Linus's tree.  But I cannot find where swiotlb_force is defined...

diff -Nru a/arch/x86_64/mm/init.c b/arch/x86_64/mm/init.c
--- a/arch/x86_64/mm/init.c     2004-06-24 01:55:57 -07:00
+++ b/arch/x86_64/mm/init.c     2004-08-24 02:08:31 -07:00

@@ -396,6 +400,8 @@
        return 0;
 }
                                                                                
+extern int swiotlb_force;
+
 static struct kcore_list kcore_mem, kcore_vmalloc, kcore_kernel, kcore_modules,                         kcore_vsyscall;
                                                                                
@@ -405,7 +411,10 @@
        int tmp;
                                                                                
 #ifdef CONFIG_SWIOTLB
-       if (!iommu_aperture && end_pfn >= 0xffffffff>>PAGE_SHIFT)
+       if (swiotlb_force)
+               swiotlb = 1;
+       if (!iommu_aperture &&
+           (end_pfn >= 0xffffffff>>PAGE_SHIFT || force_iommu))
               swiotlb = 1;
        if (swiotlb)
                swiotlb_init();


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

             reply	other threads:[~2004-08-25 18:54 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-08-25 18:54 Thomas Duffy [this message]
2004-08-28 13:48 ` x86-64 compile error in 2.6.9-rc1-bk1 Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1093460094.23633.18.camel@duffman \
    --to=thomas.duffy.99@alumni.brown.edu \
    --cc=ak@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox