From: Rusty Russell <rusty@rustcorp.com.au>
To: Christoph Hellwig <hch@infradead.org>
Cc: Tim Bird <tim.bird@am.sony.com>,
linux kernel <linux-kernel@vger.kernel.org>,
Adam Kropelin <akropel1@rochester.rr.com>,
Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH] - trivial comment fixups in init/main.c
Date: Thu, 26 Aug 2004 18:42:44 +1000 [thread overview]
Message-ID: <1093509764.13514.2522.camel@bach> (raw)
In-Reply-To: <20040817184210.A24533@infradead.org>
On Wed, 2004-08-18 at 03:42, Christoph Hellwig wrote:
> > Fine with me. These comments were modified at the request of
> > Andrew Morton, who wanted the comment style to be consistent.
> > I actually agree with your position, but I wanted to follow
> > what Andrew wanted here.
>
> Please fix the comments anyway. Rusty's preffered style is by far the
> minority in core kernel code.
I went back and looked; you're right. Generally, I hate to waste
vertical whitespace inside a function.
As I said, the balance with a color-coded editor is different than when
reading code on paper.
Cheers,
Rusty.
--
Anyone who quotes me in their signature is an idiot -- Rusty Russell
prev parent reply other threads:[~2004-08-26 9:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-13 18:39 [PATCH] - trivial comment fixups in init/main.c Tim Bird
2004-08-17 9:53 ` Rusty Russell
2004-08-17 11:45 ` Adam Kropelin
2004-08-17 17:31 ` Tim Bird
2004-08-17 17:42 ` Christoph Hellwig
2004-08-26 8:42 ` Rusty Russell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1093509764.13514.2522.camel@bach \
--to=rusty@rustcorp.com.au \
--cc=akpm@osdl.org \
--cc=akropel1@rochester.rr.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tim.bird@am.sony.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox