radeonfb: do not blank during swsusp snapshot

radeonfb: do not blank during swsusp snapshot

[Pavel Machek]

Hi!

With display blanked, it is hard to debug anything. And display
blanking is not really needed there... Does it look okay?

								Pavel

--- clean-mm.middle/drivers/video/aty/radeon_pm.c	2004-08-15 19:15:01.000000000 +0200
+++ linux-mm/drivers/video/aty/radeon_pm.c	2004-08-28 23:26:46.000000000 +0200
@@ -880,12 +880,14 @@
 		radeon_engine_idle();
 	}
 
-	/* Blank display and LCD */
-	radeonfb_blank(VESA_POWERDOWN, info);
-
-	/* Sleep */
-	rinfo->asleep = 1;
-	rinfo->lock_blank = 1;
+	if (system_state != SYSTEM_SNAPSHOT) {
+		/* Blank display and LCD */
+		radeonfb_blank(VESA_POWERDOWN, info);
+
+		/* Sleep */
+		rinfo->asleep = 1;
+		rinfo->lock_blank = 1;
+	}
 
 	/* Suspend the chip to D2 state when supported
 	 */

-- 
People were complaining that M$ turns users into beta-testers...
...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl!

Re: radeonfb: do not blank during swsusp snapshot

[Benjamin Herrenschmidt]

On Sun, 2004-08-29 at 07:35, Pavel Machek wrote:
> Hi!
> 
> With display blanked, it is hard to debug anything. And display
> blanking is not really needed there... Does it look okay?

Well... I have some patches for that, though not using the
system_state global (that I don't like, but it seems that you
decided to go that way anyways)....

You probably wnat to avoid the call to fb_set_suspend as well

Ben.

Re: radeonfb: do not blank during swsusp snapshot

[Pavel Machek]

Hi!
> > 
> > With display blanked, it is hard to debug anything. And display
> > blanking is not really needed there... Does it look okay?
> 
> Well... I have some patches for that, though not using the
> system_state global (that I don't like, but it seems that you
> decided to go that way anyways)....

It was basically akpm's idea. I don't like it much, but it is better
than existing mess.

> You probably wnat to avoid the call to fb_set_suspend as well

Ok.
-- 
Horseback riding is like software...