From: Matthew Dobson <colpatch@us.ibm.com>
To: James Bottomley <James.Bottomley@SteelEye.com>
Cc: Jesse Barnes <jbarnes@engr.sgi.com>,
Andrew Morton <akpm@osdl.org>, Linus Torvalds <torvalds@osdl.org>,
Nick Piggin <nickpiggin@yahoo.com.au>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: SMP Panic caused by [PATCH] sched: consolidate sched domains
Date: Mon, 30 Aug 2004 12:11:19 -0700 [thread overview]
Message-ID: <1093893078.10143.2.camel@arrakis> (raw)
In-Reply-To: <1093799808.10990.22.camel@mulgrave>
On Sun, 2004-08-29 at 10:16, James Bottomley wrote:
> On Sun, 2004-08-29 at 13:07, Jesse Barnes wrote:
> > I've up and downed a few CPUs on an Altix, and it seems to work ok, but that's
> > a pretty basic test. How about this?
>
> Well, like I told Bill. It's not a priori correct because now you're
> altering runtime behaviour.
>
> It may, in fact, work because if the runtime users have an additional
> restriction to online cpus, but that's not a given ... have you audited
> the code for this?
>
> James
Yeah, I don't think that patch will work so well, unless we're very
careful to mask the return values of node_to_cpumask() and
pcibus_to_cpumask() against cpu_online_map where appropriate. There are
certainly callers of these function who are expecting a map containing
online cpus.
-Matt
next prev parent reply other threads:[~2004-08-30 19:12 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-29 13:39 SMP Panic caused by [PATCH] sched: consolidate sched domains James Bottomley
2004-08-29 16:48 ` Jesse Barnes
2004-08-29 16:58 ` James Bottomley
2004-08-29 17:07 ` Jesse Barnes
2004-08-29 17:16 ` James Bottomley
2004-08-30 19:11 ` Matthew Dobson [this message]
2004-08-29 17:24 ` James Bottomley
2004-08-29 17:48 ` Nathan Lynch
2004-08-29 22:59 ` James Bottomley
2004-08-29 17:03 ` William Lee Irwin III
2004-08-29 17:09 ` James Bottomley
2004-08-29 17:22 ` William Lee Irwin III
2004-08-29 17:29 ` William Lee Irwin III
2004-08-29 17:40 ` William Lee Irwin III
2004-08-29 17:50 ` William Lee Irwin III
2004-08-29 23:13 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1093893078.10143.2.camel@arrakis \
--to=colpatch@us.ibm.com \
--cc=James.Bottomley@SteelEye.com \
--cc=akpm@osdl.org \
--cc=jbarnes@engr.sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nickpiggin@yahoo.com.au \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox