Re: [discuss] Re: [PATCH] fs/compat.c: rwsem instead of BKL around ioctl32_hash_table

Andi Kleen
2004-09-03T15:09:06Z

> Andi> If you wanted to fix it properly better make it use RCU -
> Andi> but it cannot work for the case of calling a compat handler.
>
> Based on what you just wrote, it seems to me like RCU would actually
> work fine. Is this wrong?

I meant it wouldn't work if you wanted to fix the module count assumption
I described above. Fixing it would be probably a good idea because it's a
bit of a nasty trap and kind of undocumented. But a global lock for
it is not the right way to do it, if anything you would use the
module counts.

-Andi