From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F125630F526; Mon, 27 Oct 2025 19:23:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761592992; cv=none; b=foikL2zMxOvfVy+GpzUmxxmJCWhhLDl3tOz0dKWF2GzqcHjL64uYll6DO3sdtuPkUc+cB8MzbP3xY+uuhJTICyx3M38yzvalSK2Hi2ECEL/6ISqs1h+D11dtzEk1ShlWv/J9fR7er+M8nIvfITHRMEIgbJdlZOs6dqSyuJlGGTI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761592992; c=relaxed/simple; bh=uTrTMXHYa+MgSvqmFyrlRj8NJs2QdjeXyKWclcED2Jk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Ra3p/BWtRMye0NoyBrCu26q0A4EaHg1aSSl3kXntNqj3o+31UPTuhsS/8+o7qGp9cy6V9YRk7yZLXNXkqLnkUBiyEbziUE09g7BT+92yIm6ugxxngi2Wtg3Ua/0sEe1l3VqyZFJN/nDMzI9NGArH6j6eTBOU9Fls5vzaoJDWREs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=gPKiTO1A; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="gPKiTO1A" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 75D93C4CEFD; Mon, 27 Oct 2025 19:23:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1761592991; bh=uTrTMXHYa+MgSvqmFyrlRj8NJs2QdjeXyKWclcED2Jk=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=gPKiTO1ACxs53vukMNDQBgl5Tpn58gtc7ZA/bo7QiutJ9EJ1KdJDmYZNzHP5Jje1f FvmbqPdOQIqPlxjgPg9DthVjs2cWm9w/DFxYC/q5ExXXESZPE8RHkqxTSpnbWiTldi tJynXMecooAAP6UEX2seGq4S4YmUQ1k99QqgqxRhAXnonv61mmdtLEaajKU9c2D/vK fuLCH0jZDmtNcxn0SoYecODCR50z7QONE59ii/Bt4wwpr/ffReJV2IMeRPIm0y8Ce/ CorwtOEyXKF6Wiy6qagSF89e9oV9uAJuosnoAIA+IMYBQy6JF3gMbRSB0KRUwJ6B7U lkfJDU892oOcw== Message-ID: <10945c03-8642-4c19-b0ed-ffb20c075291@kernel.org> Date: Mon, 27 Oct 2025 20:23:05 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 5/7] gpu: nova-core: add extra integer conversion functions and traits To: Joel Fernandes Cc: Alexandre Courbot , Alice Ryhl , David Airlie , Simona Vetter , Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?UTF-8?Q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Trevor Gross , John Hubbard , Alistair Popple , Timur Tabi , Edwin Peer , nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org References: <20251027-nova-as-v2-0-a26bd1d067a4@nvidia.com> <20251027-nova-as-v2-5-a26bd1d067a4@nvidia.com> From: Danilo Krummrich Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 10/27/25 8:09 PM, Joel Fernandes wrote: > Why not just implement `From` and `Into` for the types missing it then, with > adequate comments about why such conversions are Ok for the kernel, instead of > introducing a new trait? This is exactly what `From`/`Into` is for right? https://doc.rust-lang.org/reference/items/implementations.html#r-items.impl.trait.orphan-rule.intro