From: Rusty Russell <rusty@rustcorp.com.au>
To: Nick Piggin <piggin@cyberone.com.au>
Cc: Nathan Lynch <nathanl@austin.ibm.com>,
lkml - Kernel Mailing List <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>, Ingo Molnar <mingo@elte.hu>
Subject: Re: [patch 2/2] cpu hotplug notifier for updating sched domains
Date: Thu, 09 Sep 2004 20:18:44 +1000 [thread overview]
Message-ID: <1094725124.25639.18.camel@bach> (raw)
In-Reply-To: <413E6C49.5080106@cyberone.com.au>
On Wed, 2004-09-08 at 12:19, Nick Piggin wrote:
> Nathan Lynch wrote:
> >Well, we have to "lie" to arch_init_sched_domains a little bit when
> >bringing a cpu online, by setting the soon-to-be-online cpu's bit in the
> >argument mask. So I think the first patch is still necessary.
I'm still a little surprised that you don't change the domains while the
machine is frozen (ie in take_cpu_down()). This should avoid any races,
since noone can be looking at the domains at this time.
> Do you have a theoretical race here? Can we hotplug a CPU before the notifier
> is registered? (I know we *can't* because it is still earlyish boot).
No, init has so many serial assumptions that this is the least of our
worries.
Rusty.
--
Anyone who quotes me in their signature is an idiot -- Rusty Russell
next prev parent reply other threads:[~2004-09-09 10:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-07 18:50 [patch 2/2] cpu hotplug notifier for updating sched domains nathanl
2004-09-08 0:44 ` Nick Piggin
2004-09-08 2:05 ` Nathan Lynch
2004-09-08 2:19 ` Nick Piggin
2004-09-08 2:55 ` Nathan Lynch
2004-09-09 10:18 ` Rusty Russell [this message]
2004-09-09 10:31 ` Nick Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1094725124.25639.18.camel@bach \
--to=rusty@rustcorp.com.au \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=nathanl@austin.ibm.com \
--cc=piggin@cyberone.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox