public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Jakub Jelinek <jakub@redhat.com>
Cc: Linux Kernel list <linux-kernel@vger.kernel.org>,
	linuxppc64-dev <linuxppc64-dev@lists.linuxppc.org>,
	Ulrich Drepper <drepper@redhat.com>
Subject: Re: vDSO for ppc64 : Preliminary release #3
Date: Thu, 09 Sep 2004 21:55:01 +1000	[thread overview]
Message-ID: <1094730900.2543.73.camel@gaston> (raw)
In-Reply-To: <20040909091208.GY31909@devserv.devel.redhat.com>

On Thu, 2004-09-09 at 19:12, Jakub Jelinek wrote:
> On Thu, Sep 09, 2004 at 06:43:03PM +1000, Benjamin Herrenschmidt wrote:
> >  - The current glibc code for dealing with vdso's is not completely
> > appropriate for ppc64 in particular since we do need relocations to be
> > performed on the OPD section (thanks mprotect + COW, it actually works)
> > if the library is ever mapped at a differnet address than it's native
> > 0x100000 (via the new phdr for example).
> > The current glibc code forces l_relocated to 1 for all vdso's (which is
> > fine for archs without need to relocate function descriptors).
> 
> That is on purpose, even if vDSO location is randomized (e.g. on IA-32),
> no relocations should happen, so that the vDSO can be shared (unless
> written into by the debugger, that is).  ld.so knows how to deal with
> .dynamic section relocation of vDSOs.

But not with function descriptors... on archs like ppc64, a function
symbol is actually a descriptor containing the absolute address of
the actual code and the TOC pointer. (For the vDSO, the TOC pointer
is always 0 though, routines in there don't need a TOC).

So those descriptors (in the OPD section) need to be relocated if
the vDSO is mapped at it's non-native address. It works fine since
ld.so will do mprotect() on it, and the kernel implementation I've
done on ppc do support COW when mprotect enables write access. It's
also not a default case as I only expect a few apps, like emulators
and/or maybe the JVM, to request a different location because they
need finer control on their address space (unless we want randomizing
though).

So unless we change the ABI to those calls, we have to allow
relocation to happen, on ppc64.

Ulrich proposed that instead, I export the vDSO symbols as absolute
symbols containing an offset from the start of the vDSO itself. I
have to check how to generate those, but that would mean we lose the
nice "feature" of the vDSO beeing just a normal library and require
special jump trampolines to call the routines in there...

Ben.



      parent reply	other threads:[~2004-09-09 11:56 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-09-09  8:43 vDSO for ppc64 : Preliminary release #3 Benjamin Herrenschmidt
2004-09-09  9:01 ` Benjamin Herrenschmidt
2004-09-09  9:12 ` Jakub Jelinek
2004-09-09 11:22   ` Paul Mackerras
2004-09-09 11:59     ` Benjamin Herrenschmidt
2004-09-09 12:15     ` Jakub Jelinek
2004-09-09 12:38       ` Benjamin Herrenschmidt
2004-09-09 11:55   ` Benjamin Herrenschmidt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1094730900.2543.73.camel@gaston \
    --to=benh@kernel.crashing.org \
    --cc=drepper@redhat.com \
    --cc=jakub@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc64-dev@lists.linuxppc.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox