public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Nathan Bryant <nbryant@optonline.net>
Cc: john.ronciak@intel.com, ganesh.venkatesan@intel.com,
	scott.feldman@intel.com, Andrew Morton <akpm@osdl.org>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Fix for spurious interrupts on e100 resume
Date: Thu, 09 Sep 2004 17:53:50 -0700	[thread overview]
Message-ID: <1094777630.4298.19.camel@localhost> (raw)
In-Reply-To: <4140EDDD.8010808@optonline.net>

On Thu, 2004-09-09 at 19:57 -0400, Nathan Bryant wrote:
> You sure this is right? The comment seems to imply that writing the 
> reset command to the registers also clears the interrupt mask. So you 
> might need to have the e100_disable_irq() both before and after the reset.

Good point - I'm not sure.  I don't really know what would cause the
chip to raise an interrupt.  Could it do it spontaneously, in which case
there's always a window between poking the selective/software_reset and
the disable_irq?  Or is it that the chip raises an interrupt on reset,
which is masked by disabling the interrupt, but then it enables the
interrupt after the reset is complete?  Or perhaps "it's unmasked after
reset" means "after a hardware reset (power cycle)" and not by poking
the reset registers.

Well, there was definitely a real bug there before, and it works with a
bit of testing.  We'll see how it goes over the next few days (and maybe
someone who actually understands this hardware will weigh in).

	J


  reply	other threads:[~2004-09-10  0:57 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-09-09 22:36 [PATCH] Fix for spurious interrupts on e100 resume Jeremy Fitzhardinge
2004-09-09 23:57 ` Nathan Bryant
2004-09-10  0:53   ` Jeremy Fitzhardinge [this message]
2004-09-13 22:53 ` Jeremy Fitzhardinge
  -- strict thread matches above, loose matches on Subject: below --
2004-09-30 16:26 Venkatesan, Ganesh
2004-09-30 19:01 ` Jeremy Fitzhardinge
2004-09-30 19:36 ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1094777630.4298.19.camel@localhost \
    --to=jeremy@goop.org \
    --cc=akpm@osdl.org \
    --cc=ganesh.venkatesan@intel.com \
    --cc=john.ronciak@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nbryant@optonline.net \
    --cc=scott.feldman@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox