From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: "Theodore Ts'o" <tytso@mit.edu>
Cc: arjanv@redhat.com,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: The Serial Layer
Date: Fri, 10 Sep 2004 16:21:08 +0100 [thread overview]
Message-ID: <1094829666.17464.22.camel@localhost.localdomain> (raw)
In-Reply-To: <20040910143211.GA7342@thunk.org>
On Gwe, 2004-09-10 at 15:32, Theodore Ts'o wrote:
> We needed to close the line discpline in order to prevent a line
> discipline (such as ppp) from trying to write to the tty. Given there
> was an invariant that a tty always had a line discpline always, we
> reassigned it back to N_TTY. The right answer is probably to be to
> add checks to the line discpline code before they attempt to send data
> to the tty.
Ok that makes sense. So we need the same kind of ordering rules about
device->close() as we now enforce with ldisc->close(). That suggests we
simply need to call ldisc->close before device->close. I think we can
now do that safely as the device won't deliver data to a closed ldisc.
Will look into it
next prev parent reply other threads:[~2004-09-10 16:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-07 18:49 The Serial Layer Alan Cox
2004-09-07 20:06 ` Arjan van de Ven
2004-09-07 19:14 ` Alan Cox
2004-09-09 12:57 ` Theodore Ts'o
2004-09-09 16:28 ` Alan Cox
2004-09-10 14:32 ` Theodore Ts'o
2004-09-10 15:21 ` Alan Cox [this message]
2004-09-07 20:16 ` Russell King
2004-09-12 3:01 ` David Eger
2004-09-12 15:25 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1094829666.17464.22.camel@localhost.localdomain \
--to=alan@lxorguk.ukuu.org.uk \
--cc=arjanv@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox