public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Chris Wedgwood <cw@f00f.org>
Cc: "Maciej W. Rozycki" <macro@linux-mips.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Linus Torvalds <torvalds@osdl.org>
Subject: Re: [PATCH] i386 reduce spurious interrupt noise
Date: Fri, 10 Sep 2004 23:21:26 +0100	[thread overview]
Message-ID: <1094854872.18282.29.camel@localhost.localdomain> (raw)
In-Reply-To: <20040910231052.GA3078@taniwha.stupidest.org>

On Sad, 2004-09-11 at 00:10, Chris Wedgwood wrote:
> On Fri, Sep 10, 2004 at 11:23:20PM +0200, Maciej W. Rozycki wrote:
> 
> > > -	printk (KERN_INFO "APIC error on CPU%d: %02lx(%02lx)\n",
> > > +	printk (KERN_DEBUG "APIC error on CPU%d: %02lx(%02lx)\n",
> 
> > This should probably be KERN_ERR even.  This is a serious condition -- if
> > you ever get such a message, then inter-APIC messages get corrupted and
> > this affects system's stability.
> 
> These messages are very common on many platforms, infrequent (once
> very few days to twice a day at most in my observations) and seemingly
> harmless.

On a lot of 2.4 boxes they aren't harmless but thats 2.4 IPI messsage
handling bugs. People sometimes assume an IPI is delivered once - but
its not its delivered "at least once" and when you get a checksum error
like on old dual celerons you get replays.

They also identify kernel bugs in some other bit combinations so they
are useful there too. I'd say this should only go if we are sure 2.6.x
handles IPI replay properly and we mask bits off to see if its real news
or a retry.

> > > -			printk("spurious 8259A interrupt: IRQ%d.\n", irq);
> > > +			printk(KERN_DEBUG "spurious 8259A interrupt: IRQ%d.\n", irq);
> 
> > You may ever get a single message per system boot from this line.
> 
> Sometimes as boot, though often in my experience several minutes after
> boot.

The IDE layer will generate these naturally as will any other code that
happens to clear an IRQ causing event in non IRQ context. Eventually you
clear it just as the IRQ is raised, and the pulse causes the error.

This should really go.


  reply	other threads:[~2004-09-10 23:23 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-09-02 19:28 [PATCH] i386 reduce spurious interrupt noise Chris Wedgwood
2004-09-02 19:34 ` William Lee Irwin III
2004-09-02 19:47   ` Chris Wedgwood
2004-09-02 19:52     ` William Lee Irwin III
2004-09-02 19:59       ` Chris Wedgwood
2004-09-02 20:13     ` Nathan Bryant
2004-09-02 19:27       ` Alan Cox
2004-09-02 20:32         ` Chris Wedgwood
2004-09-10 21:23 ` Maciej W. Rozycki
2004-09-10 23:10   ` Chris Wedgwood
2004-09-10 22:21     ` Alan Cox [this message]
2004-09-10 23:28       ` Chris Wedgwood
2004-09-11 13:36         ` Alan Cox
2004-09-11  0:14     ` Maciej W. Rozycki
2004-09-11  0:17       ` Chris Wedgwood
2004-09-11  0:33         ` Maciej W. Rozycki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1094854872.18282.29.camel@localhost.localdomain \
    --to=alan@lxorguk.ukuu.org.uk \
    --cc=cw@f00f.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=macro@linux-mips.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox