Re: [PATCH] New QStor SATA/RAID Driver for 2.6.9-rc2

Mark Lord
2004-09-15T02:41:54Z

>Actually, its only wrong in queuecommand because that can be called in
>softirq context.
>
>Sleeping in the eh paths is fine (as long as you drop the locks that the
>EH thread has uselessly taken for you).

Good, that's how I understood it as well.

But the locking is certainly a mess as-is in the QStor driver.
Sure, it is actually all technically correct, but hard to follow.

I believe I can remove nearly all of it and really tidy things up
as a result.

Thanks guys, this has been really helpful so far.
--
Mark Lord
(hdparm keeper & the original "Linux IDE Guy")