From: Paul Fulghum <paulkf@microgate.com>
To: Alan Cox <alan@redhat.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>
Subject: Re: PATCH: tty locking for 2.6.9rc2
Date: 15 Sep 2004 11:26:35 -0500 [thread overview]
Message-ID: <1095265595.2924.27.camel@deimos.microgate.com> (raw)
In-Reply-To: <20040914163426.GA29253@devserv.devel.redhat.com>
On Tue, 2004-09-14 at 11:34, Alan Cox wrote:
> This updates the ldisc locking patch for the 2.6.9rc2 changes.
I tried this patch and can't change line disciplines.
The user program waits forever on ioctl(TIOCSETD).
I am going to add printk statements to
find out more.
Looking at your patch I have a question:
Each line discipline has a refcount.
This single refcount is modified by all
entities using that line discipline.
tty_set_ldisc() in tty_io.c waits until the
old ldisc refcount goes to zero before setting
the new ldisc. This seems to cause a problem
in the following situation:
1. two tty instances start with the same ldisc
2. first tty instance holds reference to ldisc
3. second tty instance tries to change ldisc
The second tty instance must wait for the first
tty instance to drop the ldisc reference before
it can change to a new ldisc.
Each tty instance should be able to change
line discipline independant of other tty instances.
Or am I not understanding this correctly?
--
Paul Fulghum
paulkf@microgate.com
next prev parent reply other threads:[~2004-09-15 16:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-14 16:34 PATCH: tty locking for 2.6.9rc2 Alan Cox
2004-09-15 16:26 ` Paul Fulghum [this message]
2004-09-15 16:30 ` Alan Cox
2004-09-15 18:54 ` Paul Fulghum
2004-09-15 20:08 ` Alan Cox
2004-09-15 20:23 ` Paul Fulghum
2004-09-15 20:40 ` Alan Cox
2004-09-15 20:53 ` Paul Fulghum
-- strict thread matches above, loose matches on Subject: below --
2004-09-24 0:36 Ulisses
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1095265595.2924.27.camel@deimos.microgate.com \
--to=paulkf@microgate.com \
--cc=akpm@osdl.org \
--cc=alan@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox