From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S267404AbUIOU0r (ORCPT ); Wed, 15 Sep 2004 16:26:47 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S267391AbUIOUYG (ORCPT ); Wed, 15 Sep 2004 16:24:06 -0400 Received: from clock-tower.bc.nu ([81.2.110.250]:9411 "EHLO localhost.localdomain") by vger.kernel.org with ESMTP id S267388AbUIOUXh (ORCPT ); Wed, 15 Sep 2004 16:23:37 -0400 Subject: Re: [PATCH] hvc_console fix to protect hvc_write against ldisc write after hvc_close From: Alan Cox To: Ryan Arnold Cc: Andrew Morton , Linux Kernel Mailing List In-Reply-To: <1095273835.3294.278.camel@localhost> References: <1095273835.3294.278.camel@localhost> Content-Type: text/plain Content-Transfer-Encoding: 7bit Message-Id: <1095276020.20569.2.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Ximian Evolution 1.4.6 (1.4.6-2) Date: Wed, 15 Sep 2004 20:20:21 +0100 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Mer, 2004-09-15 at 19:43, Ryan Arnold wrote: > So this patch checks tty->driver_data in hvc_write() before it is used. > Hopefully once Alan Cox's patch is checked in ldisc writes won't > continue to happen after tty closes. Actually for the short term I may have made the ldisc calling tty race worse. I'm still looking into some of that. I've fixed the one the other way but for now driver defensively 8)