From: Ryan Arnold <rsa@us.ibm.com>
To: "Theodore Ts'o" <tytso@mit.edu>
Cc: Andrew Morton <akpm@osdl.org>,
Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] hvc_console fix to protect hvc_write against ldisc write after hvc_close
Date: Wed, 15 Sep 2004 17:35:49 -0500 [thread overview]
Message-ID: <1095287748.3294.423.camel@localhost> (raw)
In-Reply-To: <20040915204107.GA26776@thunk.org>
On Wed, 2004-09-15 at 15:41, Theodore Ts'o wrote:
> The current (I can't speak to what Alan Cox is going to change) rules
> with tty drivers is that tty drivers are supposed to close the line
> discpline in their close routines. That's the much safer and cleaner
> way of fixing this problem, and it is in line with what most of the
> other tty drivers are doing.
- Ted
Thanks for the pointer Ted. I've looked through the drivers/char
directory but I must be blind because all I see other drivers doing is
setting tty->closing = 1 (and then = 0 later) and
ldsic->flush_buffer(). Is flush_buffer() what you're refering to? The
tty->closing variable just seems to prevent the ldisc from reading.
Ryan S. Arnold
IBM Linux Technology Center
next prev parent reply other threads:[~2004-09-15 22:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-15 18:43 [PATCH] hvc_console fix to protect hvc_write against ldisc write after hvc_close Ryan Arnold
2004-09-15 19:20 ` Alan Cox
2004-09-15 21:23 ` Ryan Arnold
2004-09-15 20:41 ` Theodore Ts'o
2004-09-15 21:36 ` Alan Cox
2004-09-15 22:35 ` Ryan Arnold [this message]
2004-09-24 1:15 ` ldisc writes during tty release_dev() causing problems Ryan Arnold
2004-09-24 12:40 ` Alan Cox
2004-09-24 16:18 ` Ryan Arnold
2004-09-24 15:30 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1095287748.3294.423.camel@localhost \
--to=rsa@us.ibm.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox