From: Albert Cahalan <albert@users.sf.net>
To: linux-kernel mailing list <linux-kernel@vger.kernel.org>
Cc: ak@muc.de
Subject: get_current is __pure__, maybe __const__ even
Date: 15 Sep 2004 18:50:00 -0400 [thread overview]
Message-ID: <1095288600.1174.5968.camel@cube> (raw)
Andi Kleen writes:
> Please CSE "current" manually. It generates
> much better code on some architectures
> because the compiler cannot do it for you.
This looks fixable.
At the very least, __attribute__((__pure__))
will apply to your get_current function.
I think __attribute__((__const__)) will too,
even though it's technically against the
documentation. While you do indeed read from
memory, you don't read from memory that could
be seen as changing. Nothing done during the
lifetime of a task will change "current" as
viewed from within that task.
next reply other threads:[~2004-09-15 23:00 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-15 22:50 Albert Cahalan [this message]
2004-09-15 23:15 ` get_current is __pure__, maybe __const__ even Jakub Jelinek
2004-09-15 23:29 ` William Lee Irwin III
2004-09-16 2:10 ` Albert Cahalan
2004-09-16 2:36 ` William Lee Irwin III
2004-09-16 2:47 ` Nick Piggin
2004-09-16 3:23 ` William Lee Irwin III
2004-09-16 3:49 ` Albert Cahalan
2004-09-16 3:59 ` William Lee Irwin III
2004-09-16 9:04 ` Russell King
2004-09-16 9:11 ` Andi Kleen
2004-09-16 9:30 ` Russell King
2004-09-16 11:03 ` Andi Kleen
2004-09-16 14:36 ` Russell King
2004-09-15 23:27 ` William Lee Irwin III
[not found] <2ER4z-46B-17@gated-at.bofh.it>
2004-09-16 6:58 ` Andi Kleen
2004-09-16 13:43 ` Albert Cahalan
2004-09-16 14:14 ` Albert Cahalan
2004-09-16 19:27 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1095288600.1174.5968.camel@cube \
--to=albert@users.sf.net \
--cc=ak@muc.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox