public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Albert Cahalan <albert@users.sf.net>
To: Andi Kleen <ak@muc.de>
Cc: Albert Cahalan <albert@users.sourceforge.net>,
	linux-kernel mailing list <linux-kernel@vger.kernel.org>
Subject: Re: get_current is __pure__, maybe __const__ even
Date: 16 Sep 2004 09:43:01 -0400	[thread overview]
Message-ID: <1095342181.3866.1316.camel@cube> (raw)
In-Reply-To: <m3llfaya29.fsf@averell.firstfloor.org>

On Thu, 2004-09-16 at 02:58, Andi Kleen wrote:
> Albert Cahalan <albert@users.sf.net> writes:
> 
> > Andi Kleen writes:
> >
> >> Please CSE "current" manually. It generates
> >> much better code on some architectures
> >> because the compiler cannot do it for you.
> >
> > This looks fixable.
> 
> I tried it some years ago, but I ran into problems with the scheduler
> and some other code and dropped it.

Since then, have you changed:

a. the minimum required compiler version?
b. the clobbers on your switch_to asm?

If not, maybe you should.

> One problem is that gcc doesn't have a "drop all const/pure
> cache values" barrier. Without this I don't think it can be 
> safely implemented.

That's only if gcc can find some place to
hide state which will contaminate another task.
Where could that be? Remember, arm works.

Also, glibc works, with per-thread errno:

/* Function to get address of global `errno' variable.  */
extern int *__errno_location (void) __THROW __attribute__ ((__const__));

/* Function to get address of global `h_errno' variable.  */
extern int *__h_errno_location (void) __THROW __attribute__ ((__const__));



  reply	other threads:[~2004-09-16 13:47 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <2ER4z-46B-17@gated-at.bofh.it>
2004-09-16  6:58 ` get_current is __pure__, maybe __const__ even Andi Kleen
2004-09-16 13:43   ` Albert Cahalan [this message]
2004-09-16 14:14   ` Albert Cahalan
2004-09-16 19:27     ` Andi Kleen
2004-09-15 22:50 Albert Cahalan
2004-09-15 23:15 ` Jakub Jelinek
2004-09-15 23:29   ` William Lee Irwin III
2004-09-16  2:10     ` Albert Cahalan
2004-09-16  2:36       ` William Lee Irwin III
2004-09-16  2:47         ` Nick Piggin
2004-09-16  3:23           ` William Lee Irwin III
2004-09-16  3:49         ` Albert Cahalan
2004-09-16  3:59           ` William Lee Irwin III
2004-09-16  9:04         ` Russell King
2004-09-16  9:11           ` Andi Kleen
2004-09-16  9:30             ` Russell King
2004-09-16 11:03               ` Andi Kleen
2004-09-16 14:36                 ` Russell King
2004-09-15 23:27 ` William Lee Irwin III

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1095342181.3866.1316.camel@cube \
    --to=albert@users.sf.net \
    --cc=ak@muc.de \
    --cc=albert@users.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox