Re: [RFC][PATCH] inotify 0.9.2

John McCutchan
2004-09-22T02:02:40Z

On Tue, 2004-09-21 at 11:43, Chris Friesen wrote:
> Edgar Toernig wrote:
> > Robert Love wrote:
> >
> >> struct inotify_event {
> >> int wd;
> >> int mask;
> >>- char filename[256];
> >>+ char filename[PATH_MAX];
> >> };
> >
> >
> > You really want to shove >4kB per event to userspace???
>
> Ouch.
>
> Maybe make it variable-size? On average it would likely be shorter.
>
> struct inotify_event {
> int wd;
> int mask;
> short namelen;
> char filename[0];
> };

This makes reading events from inotify a pain, first you need to read up
to namelen, then read namelen more bytes.

John