* [PATCH] ppc32: Fix potentially uninitialized var in chrp_setup.c
@ 2004-09-24 0:21 Benjamin Herrenschmidt
0 siblings, 0 replies; only message in thread
From: Benjamin Herrenschmidt @ 2004-09-24 0:21 UTC (permalink / raw)
To: Andrew Morton; +Cc: Linus Torvalds, Linux Kernel list
Hi !
In chrp_setup.c, chrp_int_ack could be left uninitialized and passed
"as-is" to i8259_init() if the OF node for the 8259 wasn't found. I
don't know if that should happen, but the i8259 code can deal with
int_ack beeing 0, so let's be safe, initialize it, and remove a
warning at the same time.
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
===== arch/ppc/platforms/chrp_setup.c 1.34 vs edited =====
--- 1.34/arch/ppc/platforms/chrp_setup.c 2004-08-17 02:04:08 +10:00
+++ edited/arch/ppc/platforms/chrp_setup.c 2004-09-24 10:19:34 +10:00
@@ -375,7 +375,7 @@
{
struct device_node *np;
int i;
- unsigned long chrp_int_ack;
+ unsigned long chrp_int_ack = 0;
unsigned char init_senses[NR_IRQS - NUM_8259_INTERRUPTS];
#if defined(CONFIG_VT) && defined(CONFIG_INPUT_ADBHID) && defined(XMON)
struct device_node *kbd;
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2004-09-24 0:28 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-09-24 0:21 [PATCH] ppc32: Fix potentially uninitialized var in chrp_setup.c Benjamin Herrenschmidt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox