From: Paul Fulghum <paulkf@microgate.com>
To: scott.feldman@intel.com
Cc: linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: 2.6.9-rc2-mm4 e100 enable_irq unbalanced from
Date: Mon, 27 Sep 2004 16:12:39 -0500 [thread overview]
Message-ID: <1096319558.3859.5.camel@deimos.microgate.com> (raw)
In-Reply-To: <1096313095.2601.20.camel@deimos.microgate.com>
On Mon, 2004-09-27 at 14:24, Paul Fulghum wrote:
> The e100 module is generating a warning:
>
> Sep 27 13:30:29 deimos kernel: e100: Intel(R) PRO/100 Network Driver, 3.1.4-NAPI
> Sep 27 13:30:29 deimos kernel: e100: Copyright(c) 1999-2004 Intel Corporation
> Sep 27 13:30:29 deimos kernel: e100: eth0: e100_probe: addr 0xfecfc000, irq 16, MAC addr 00:90:27:3A:C5:E3
> Sep 27 13:30:29 deimos kernel: enable_irq(16) unbalanced from ec83ff33
> Sep 27 13:30:29 deimos kernel: [<c010923f>] enable_irq+0xcf/0xe0
> Sep 27 13:30:29 deimos kernel: [<ec83ff33>] e100_up+0xf3/0x1f0 [e100]
The following patch works for me and removes the warning.
The disable_irq/enable_irq is not needed because
the ISR can't be called before calling request_irq,
the hardware is initialized before calling request_irq,
and request_irq itself enables the interrupt if needed.
Comments?
--
Paul Fulghum
paulkf@microgate.com
--- a/drivers/net/e100.c 2004-09-27 09:57:35.000000000 -0500
+++ b/drivers/net/e100.c 2004-09-27 16:00:12.115482112 -0500
@@ -1675,9 +1675,6 @@
if((err = e100_rx_alloc_list(nic)))
return err;
-
- disable_irq(nic->pdev->irq);
-
if((err = e100_alloc_cbs(nic)))
goto err_rx_clean_list;
if((err = e100_hw_init(nic)))
@@ -1689,7 +1686,6 @@
nic->netdev->name, nic->netdev)))
goto err_no_irq;
e100_enable_irq(nic);
- enable_irq(nic->pdev->irq);
netif_wake_queue(nic->netdev);
return 0;
@@ -1700,7 +1696,6 @@
err_rx_clean_list:
e100_rx_clean_list(nic);
- enable_irq(nic->pdev->irq);
return err;
}
next prev parent reply other threads:[~2004-09-27 21:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-27 19:24 2.6.9-rc2-mm4 e100 enable_irq unbalanced from Paul Fulghum
2004-09-27 21:12 ` Paul Fulghum [this message]
2004-09-30 18:21 ` Jeremy Fitzhardinge
2004-09-27 23:00 ` J.A. Magallon
2004-09-27 23:09 ` Paul Fulghum
2004-09-28 22:13 ` J.A. Magallon
-- strict thread matches above, loose matches on Subject: below --
2004-09-28 21:03 Feldman, Scott
2004-09-29 3:06 ` Paul Fulghum
2004-09-29 12:13 ` Alan Cox
2004-09-29 13:31 ` Russell King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1096319558.3859.5.camel@deimos.microgate.com \
--to=paulkf@microgate.com \
--cc=linux-kernel@vger.kernel.org \
--cc=scott.feldman@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox