public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ppc64: Fix incorrect initialization of hash table on some pSeries
@ 2004-09-30  5:36 Benjamin Herrenschmidt
  0 siblings, 0 replies; 2+ messages in thread
From: Benjamin Herrenschmidt @ 2004-09-30  5:36 UTC (permalink / raw)
  To: Andrew Morton; +Cc: Linus Torvalds, Linux Kernel list, Olaf Hering

Hi !

The hash table wasn't fully initialized on some pSeries that had
the workaround for no batching. Please apply.

===== arch/ppc64/mm/hash_native.c 1.18 vs edited =====
--- 1.18/arch/ppc64/mm/hash_native.c	2004-09-22 14:40:30 +10:00
+++ edited/arch/ppc64/mm/hash_native.c	2004-09-30 15:34:39 +10:00
@@ -407,13 +407,13 @@
 		model = get_property(root, "model", NULL);
 		if (!strcmp(model, "CHRP IBM,9076-N81")) {
 			of_node_put(root);
-			return;
+			goto bail;
 		}
 		of_node_put(root);
 	}
 #endif /* CONFIG_PPC_PSERIES */
 
 	ppc_md.flush_hash_range = native_flush_hash_range;
-
+ bail:
 	htab_finish_init();
 }



^ permalink raw reply	[flat|nested] 2+ messages in thread

* [PATCH] ppc64: Fix incorrect initialization of hash table on some pSeries
@ 2004-09-30  5:39 Benjamin Herrenschmidt
  0 siblings, 0 replies; 2+ messages in thread
From: Benjamin Herrenschmidt @ 2004-09-30  5:39 UTC (permalink / raw)
  To: Andrew Morton; +Cc: Linus Torvalds, Linux Kernel list, Olaf Hering

Hi !

The hash table wasn't fully initialized on some pSeries that had
the workaround for no batching. Please apply.

Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>

===== arch/ppc64/mm/hash_native.c 1.18 vs edited =====
--- 1.18/arch/ppc64/mm/hash_native.c	2004-09-22 14:40:30 +10:00
+++ edited/arch/ppc64/mm/hash_native.c	2004-09-30 15:34:39 +10:00
@@ -407,13 +407,13 @@
 		model = get_property(root, "model", NULL);
 		if (!strcmp(model, "CHRP IBM,9076-N81")) {
 			of_node_put(root);
-			return;
+			goto bail;
 		}
 		of_node_put(root);
 	}
 #endif /* CONFIG_PPC_PSERIES */
 
 	ppc_md.flush_hash_range = native_flush_hash_range;
-
+ bail:
 	htab_finish_init();
 }



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2004-09-30  5:43 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-09-30  5:36 [PATCH] ppc64: Fix incorrect initialization of hash table on some pSeries Benjamin Herrenschmidt
  -- strict thread matches above, loose matches on Subject: below --
2004-09-30  5:39 Benjamin Herrenschmidt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox