From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Bjorn Helgaas <bjorn.helgaas@hp.com>
Cc: Linux Kernel list <linux-kernel@vger.kernel.org>
Subject: Re: [RFC][PATCH] Way for platforms to alter built-in serial ports
Date: Fri, 01 Oct 2004 09:53:30 +1000 [thread overview]
Message-ID: <1096588409.3083.34.camel@gaston> (raw)
In-Reply-To: <200409301014.00725.bjorn.helgaas@hp.com>
On Fri, 2004-10-01 at 02:14, Bjorn Helgaas wrote:
> This looks like a reasonable short-term fix, but I think the whole
> serial8250_isa_init_ports() should go away. I like dwmw2's suggestion
> of an 8250_platform.c that could use register_serial() for each port
> in some platform-supplied old_serial_port[] table, which is probably
> what you mean by moving to a more dynamic allocation.
What would this file look like ? a bunch of platform #ifdef's with
different implementations each time ?
> AFAICS, the only reason for doing serial8250_isa_init_ports() early
> is for early serial consoles, and I think those should be done along
> the lines of this:
> http://www.ussg.iu.edu/hypermail/linux/kernel/0409.1/1034.html
> where the platform can specify a device by its MMIO or IO port address,
> and we automatically switch to the corresponding ttyS device later.
Eventually...
In the meantime, that patch would fix urgent problems for ppc now so
I'd appreciate if Russell would consider it for inclusion asap. This
is the kind of subject on which everybody comes up with a different
"better" way to do it and no code, and nothign ever gets implemented
and we end up with no progress...
Ben.
next prev parent reply other threads:[~2004-09-30 23:57 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-30 16:14 [RFC][PATCH] Way for platforms to alter built-in serial ports Bjorn Helgaas
2004-09-30 23:53 ` Benjamin Herrenschmidt [this message]
2004-10-01 14:58 ` Bjorn Helgaas
2004-10-02 6:45 ` Benjamin Herrenschmidt
2004-10-06 7:32 ` Russell King
2004-10-06 19:54 ` Bjorn Helgaas
2004-10-08 19:49 ` Bjorn Helgaas
2004-10-06 7:29 ` Russell King
2004-10-06 19:47 ` Bjorn Helgaas
2004-11-01 17:15 ` David Woodhouse
2004-11-02 16:39 ` Bjorn Helgaas
2004-11-03 7:43 ` Russell King
2004-11-03 12:07 ` David Woodhouse
-- strict thread matches above, loose matches on Subject: below --
2004-09-30 8:50 Benjamin Herrenschmidt
2004-10-06 7:26 ` Russell King
2004-10-06 8:15 ` Benjamin Herrenschmidt
2004-10-06 9:07 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1096588409.3083.34.camel@gaston \
--to=benh@kernel.crashing.org \
--cc=bjorn.helgaas@hp.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox