From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Linus Torvalds <torvalds@osdl.org>
Cc: Andrew Morton <akpm@osdl.org>, Marcel Sebek <sebek64@post.cz>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [2.6.9-rc3-bk1] Sleeping function called from invalid context
Date: Sat, 02 Oct 2004 19:57:37 +0100 [thread overview]
Message-ID: <1096743455.25292.22.camel@localhost.localdomain> (raw)
In-Reply-To: <Pine.LNX.4.58.0410021201340.2301@ppc970.osdl.org>
On Sad, 2004-10-02 at 20:08, Linus Torvalds wrote:
> We might be able to change it to a per-tty semaphore instead, which sounds
> reasonably safe, but in the meantime I don't think we have any other
> choice than to just leave the driver/ldisc routines unprotected. They
> should be just reading the state, after all.
Yep - already discussed on the linux-kernel and linux-usb lists. You can
do it with a semaphore. Its currently in testing. The USB drivers need
to sleep in order to handle the fact that their change is an
asynchronous message.
We do actually have to lock it or some drivers crash when you do the
fork 100 processes and all keep doing termios stuff attack.
Will send you a patch once its finished the test runs
Alan
prev parent reply other threads:[~2004-10-02 20:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-01 20:35 [2.6.9-rc3-bk1] Sleeping function called from invalid context Marcel Sebek
2004-10-02 3:56 ` Andrew Morton
2004-10-02 19:08 ` Linus Torvalds
2004-10-02 18:57 ` Alan Cox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1096743455.25292.22.camel@localhost.localdomain \
--to=alan@lxorguk.ukuu.org.uk \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sebek64@post.cz \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox