From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Pavel Machek <pavel@ucw.cz>
Cc: Linux Kernel list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] -mm swsusp: copy_page is harmfull
Date: Mon, 04 Oct 2004 09:50:14 +1000 [thread overview]
Message-ID: <1096847414.23142.42.camel@gaston> (raw)
In-Reply-To: <200409292014.i8TKEhov023334@hera.kernel.org>
On Sat, 2004-09-25 at 10:27, Linux Kernel Mailing List wrote:
> ChangeSet 1.1983.1.3, 2004/09/24 17:27:41-07:00, akpm@osdl.org
>
> [PATCH] -mm swsusp: copy_page is harmfull
>
> From: Pavel Machek <pavel@ucw.cz>
>
> This is my fault from long time ago: copy_page can't be used for copying
> task struct, therefore we can't use it in swsusp.
Hi !
Just curious, but why ?
It would be useful to have this in platform code, I don't see why I couldn't
use copy_page() on ppc and I suspect it will be more efficient than memcpy
since it has specific optimisations due to the fact that we are known to be
fully aligned and the size of the copy is a constant aligned power of 2.
Ben.
next parent reply other threads:[~2004-10-03 23:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200409292014.i8TKEhov023334@hera.kernel.org>
2004-10-03 23:50 ` Benjamin Herrenschmidt [this message]
2004-10-04 8:12 ` [PATCH] -mm swsusp: copy_page is harmfull Nigel Cunningham
2004-10-04 9:33 ` Pavel Machek
2004-10-04 11:20 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1096847414.23142.42.camel@gaston \
--to=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox