* [PATCH] scheduler: remove NODE_BALANCE_RATE definitions
@ 2004-10-06 1:08 Matthew Dobson
2004-10-06 1:11 ` Nick Piggin
0 siblings, 1 reply; 2+ messages in thread
From: Matthew Dobson @ 2004-10-06 1:08 UTC (permalink / raw)
To: Andrew Morton, LKML, Nick Piggin, Martin J. Bligh
NODE_BALANCE_RATE is defined all over the place, but used nowhere.
Let's remove it.
[mcd@arrakis source]$ diffstat ~/linux/patches/remove-NODE_BALANCE_RATE.patch
asm-alpha/topology.h | 3 ---
asm-generic/topology.h | 5 -----
asm-i386/topology.h | 3 ---
asm-ia64/topology.h | 3 ---
asm-m32r/topology.h | 5 -----
asm-mips/mach-ip27/topology.h | 3 ---
asm-ppc64/topology.h | 3 ---
asm-x86_64/topology.h | 2 --
8 files changed, 27 deletions(-)
-Matt
diff -Nurp --exclude-from=/home/mcd/.dontdiff linux-2.6.9-rc3-mm2/include/asm-alpha/topology.h linux-2.6.9-rc3-mm2-NODE_BALANCE_RATE/include/asm-alpha/topology.h
--- linux-2.6.9-rc3-mm2/include/asm-alpha/topology.h 2004-08-13 22:36:32.000000000 -0700
+++ linux-2.6.9-rc3-mm2-NODE_BALANCE_RATE/include/asm-alpha/topology.h 2004-10-05 18:03:01.000000000 -0700
@@ -39,9 +39,6 @@ static inline cpumask_t node_to_cpumask(
return node_cpu_mask;
}
-/* Cross-node load balancing interval. */
-# define NODE_BALANCE_RATE 10
-
#define pcibus_to_cpumask(bus) (cpu_online_map)
#else /* CONFIG_NUMA */
diff -Nurp --exclude-from=/home/mcd/.dontdiff linux-2.6.9-rc3-mm2/include/asm-generic/topology.h linux-2.6.9-rc3-mm2-NODE_BALANCE_RATE/include/asm-generic/topology.h
--- linux-2.6.9-rc3-mm2/include/asm-generic/topology.h 2004-08-13 22:36:16.000000000 -0700
+++ linux-2.6.9-rc3-mm2-NODE_BALANCE_RATE/include/asm-generic/topology.h 2004-10-05 18:01:16.000000000 -0700
@@ -45,9 +45,4 @@
#define pcibus_to_cpumask(bus) (cpu_online_map)
#endif
-/* Cross-node load balancing interval. */
-#ifndef NODE_BALANCE_RATE
-#define NODE_BALANCE_RATE 10
-#endif
-
#endif /* _ASM_GENERIC_TOPOLOGY_H */
diff -Nurp --exclude-from=/home/mcd/.dontdiff linux-2.6.9-rc3-mm2/include/asm-i386/topology.h linux-2.6.9-rc3-mm2-NODE_BALANCE_RATE/include/asm-i386/topology.h
--- linux-2.6.9-rc3-mm2/include/asm-i386/topology.h 2004-10-04 14:38:56.000000000 -0700
+++ linux-2.6.9-rc3-mm2-NODE_BALANCE_RATE/include/asm-i386/topology.h 2004-10-05 18:01:27.000000000 -0700
@@ -69,9 +69,6 @@ static inline cpumask_t pcibus_to_cpumas
/* Node-to-Node distance */
#define node_distance(from, to) ((from) != (to))
-/* Cross-node load balancing interval. */
-#define NODE_BALANCE_RATE 100
-
/* sched_domains SD_NODE_INIT for NUMAQ machines */
#define SD_NODE_INIT (struct sched_domain) { \
.span = CPU_MASK_NONE, \
diff -Nurp --exclude-from=/home/mcd/.dontdiff linux-2.6.9-rc3-mm2/include/asm-ia64/topology.h linux-2.6.9-rc3-mm2-NODE_BALANCE_RATE/include/asm-ia64/topology.h
--- linux-2.6.9-rc3-mm2/include/asm-ia64/topology.h 2004-10-04 14:38:56.000000000 -0700
+++ linux-2.6.9-rc3-mm2-NODE_BALANCE_RATE/include/asm-ia64/topology.h 2004-10-05 18:01:39.000000000 -0700
@@ -40,9 +40,6 @@
*/
#define node_to_first_cpu(node) (__ffs(node_to_cpumask(node)))
-/* Cross-node load balancing interval. */
-#define NODE_BALANCE_RATE 10
-
void build_cpu_to_node_map(void);
/* sched_domains SD_NODE_INIT for IA64 NUMA machines */
diff -Nurp --exclude-from=/home/mcd/.dontdiff linux-2.6.9-rc3-mm2/include/asm-m32r/topology.h linux-2.6.9-rc3-mm2-NODE_BALANCE_RATE/include/asm-m32r/topology.h
--- linux-2.6.9-rc3-mm2/include/asm-m32r/topology.h 2004-09-30 11:15:16.000000000 -0700
+++ linux-2.6.9-rc3-mm2-NODE_BALANCE_RATE/include/asm-m32r/topology.h 2004-10-05 18:03:13.000000000 -0700
@@ -45,9 +45,4 @@
#define pcibus_to_cpumask(bus) (cpu_online_map)
#endif
-/* Cross-node load balancing interval. */
-#ifndef NODE_BALANCE_RATE
-#define NODE_BALANCE_RATE 10
-#endif
-
#endif /* _ASM_M32R_TOPOLOGY_H */
diff -Nurp --exclude-from=/home/mcd/.dontdiff linux-2.6.9-rc3-mm2/include/asm-mips/mach-ip27/topology.h linux-2.6.9-rc3-mm2-NODE_BALANCE_RATE/include/asm-mips/mach-ip27/topology.h
--- linux-2.6.9-rc3-mm2/include/asm-mips/mach-ip27/topology.h 2004-08-13 22:38:11.000000000 -0700
+++ linux-2.6.9-rc3-mm2-NODE_BALANCE_RATE/include/asm-mips/mach-ip27/topology.h 2004-10-05 18:02:44.000000000 -0700
@@ -12,7 +12,4 @@
extern int node_distance(nasid_t nasid_a, nasid_t nasid_b);
#define node_distance(from, to) node_distance(from, to)
-/* Cross-node load balancing interval. */
-#define NODE_BALANCE_RATE 10
-
#endif /* _ASM_MACH_TOPOLOGY_H */
diff -Nurp --exclude-from=/home/mcd/.dontdiff linux-2.6.9-rc3-mm2/include/asm-ppc64/topology.h linux-2.6.9-rc3-mm2-NODE_BALANCE_RATE/include/asm-ppc64/topology.h
--- linux-2.6.9-rc3-mm2/include/asm-ppc64/topology.h 2004-10-04 14:38:56.000000000 -0700
+++ linux-2.6.9-rc3-mm2-NODE_BALANCE_RATE/include/asm-ppc64/topology.h 2004-10-05 18:02:19.000000000 -0700
@@ -37,9 +37,6 @@ static inline int node_to_first_cpu(int
#define nr_cpus_node(node) (nr_cpus_in_node[node])
-/* Cross-node load balancing interval. */
-#define NODE_BALANCE_RATE 10
-
/* sched_domains SD_NODE_INIT for PPC64 machines */
#define SD_NODE_INIT (struct sched_domain) { \
.span = CPU_MASK_NONE, \
diff -Nurp --exclude-from=/home/mcd/.dontdiff linux-2.6.9-rc3-mm2/include/asm-x86_64/topology.h linux-2.6.9-rc3-mm2-NODE_BALANCE_RATE/include/asm-x86_64/topology.h
--- linux-2.6.9-rc3-mm2/include/asm-x86_64/topology.h 2004-10-04 14:38:57.000000000 -0700
+++ linux-2.6.9-rc3-mm2-NODE_BALANCE_RATE/include/asm-x86_64/topology.h 2004-10-05 18:01:52.000000000 -0700
@@ -32,8 +32,6 @@ static inline cpumask_t __pcibus_to_cpum
/* broken generic file uses #ifndef later on this */
#define pcibus_to_cpumask(bus) __pcibus_to_cpumask(bus)
-#define NODE_BALANCE_RATE 30 /* CHECKME */
-
#ifdef CONFIG_NUMA
/* sched_domains SD_NODE_INIT for x86_64 machines */
#define SD_NODE_INIT (struct sched_domain) { \
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] scheduler: remove NODE_BALANCE_RATE definitions
2004-10-06 1:08 [PATCH] scheduler: remove NODE_BALANCE_RATE definitions Matthew Dobson
@ 2004-10-06 1:11 ` Nick Piggin
0 siblings, 0 replies; 2+ messages in thread
From: Nick Piggin @ 2004-10-06 1:11 UTC (permalink / raw)
To: colpatch; +Cc: Andrew Morton, LKML, Martin J. Bligh
Matthew Dobson wrote:
> NODE_BALANCE_RATE is defined all over the place, but used nowhere.
> Let's remove it.
>
Yep that looks good. Andrew, can you queue this for when 2.6.10 opens
please.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2004-10-06 1:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-10-06 1:08 [PATCH] scheduler: remove NODE_BALANCE_RATE definitions Matthew Dobson
2004-10-06 1:11 ` Nick Piggin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox