From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S266477AbUJIBHT (ORCPT ); Fri, 8 Oct 2004 21:07:19 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S266474AbUJIBHS (ORCPT ); Fri, 8 Oct 2004 21:07:18 -0400 Received: from gate.crashing.org ([63.228.1.57]:36269 "EHLO gate.crashing.org") by vger.kernel.org with ESMTP id S266459AbUJIBGx (ORCPT ); Fri, 8 Oct 2004 21:06:53 -0400 Subject: Re: [PATCH] amd8111e endian & barrier fixes From: Benjamin Herrenschmidt To: Andi Kleen Cc: Jeff Garzik , Linux Kernel list , khawar.chaudhry@amd.com, reeja.john@amd.com In-Reply-To: References: <2MWTy-5mO-5@gated-at.bofh.it> Content-Type: text/plain Message-Id: <1097283973.3605.11.camel@gaston> Mime-Version: 1.0 X-Mailer: Ximian Evolution 1.4.6 Date: Sat, 09 Oct 2004 11:06:13 +1000 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2004-10-08 at 21:47, Andi Kleen wrote: > It's basically impossible to review the patch properly because > of that change. Can you please separate the arbitary white space > change into a different patch? Hrm... I think you are doing too much here ;) The change concerns only a single function and is still quite readable :) But anyways, I'll eventually do that next week. > Also I would suggest you send the patch to the driver > maintainers for review first (cc'ed) Well, I would have done if any maintainer email was in the source code, which isn't the case, but thanks for providing them :) > >From a quick look the change to clear the ring rx flags completely > instead of clearing the bit looks bogus. Why did you not just add a > endian conversion there? Because the bits mask was ... 0 :) > I can test it when it's properly reviewd. Sure. No hurry. Ben