From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S266175AbUJNOqL (ORCPT ); Thu, 14 Oct 2004 10:46:11 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S265477AbUJNOqK (ORCPT ); Thu, 14 Oct 2004 10:46:10 -0400 Received: from stat16.steeleye.com ([209.192.50.48]:45712 "EHLO hancock.sc.steeleye.com") by vger.kernel.org with ESMTP id S265331AbUJNOiF (ORCPT ); Thu, 14 Oct 2004 10:38:05 -0400 Subject: Re: cciss update [2/2] fixes for Steeleye Lifekeeper From: James Bottomley To: Christoph Hellwig Cc: mikem@beardog.cca.cpqcorp.net, Andrew Morton , Jens Axboe , Linux Kernel , SCSI Mailing List In-Reply-To: <20041014083900.GB7747@infradead.org> References: <20041013212253.GB9866@beardog.cca.cpqcorp.net> <20041014083900.GB7747@infradead.org> Content-Type: text/plain Content-Transfer-Encoding: 7bit X-Mailer: Ximian Evolution 1.0.8 (1.0.8-9) Date: 14 Oct 2004 09:37:32 -0500 Message-Id: <1097764660.2198.11.camel@mulgrave> Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2004-10-14 at 03:39, Christoph Hellwig wrote: > No, this is bogus. Never call add_disk on a volume that hasn't been > configured and full set up. If you need to talk to our driver without > online volumes add a character device. I don't think so ... it's a volume you know exists but you can't get access to (in a shared storage configuration). In SCSI we have two examples of this now: 1. The case where the device responds to inquiry but errors read capacity (usually because of a reservation conflict). Here we configure a totally bogus 1GB volume with 512 byte sectors. 2. The case where the device has an illegal sector size. Here we configure a zero size volume. In both cases we expose the device in sd but make it effectively inaccessible because we want to be able to send ioctls to it but not allow ordinary read/writes. (Although I'd really like not to configure a bogus size in case 1.). I don't see how the cciss case is any different from this. James