public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: James Bottomley <James.Bottomley@SteelEye.com>
To: Andrew Morton <akpm@osdl.org>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>, mingo@elte.hu
Subject: Re: [PATCH] add unschedule_delayed_work to the workqueue API
Date: 18 Oct 2004 16:26:57 -0500	[thread overview]
Message-ID: <1098134824.2011.322.camel@mulgrave> (raw)
In-Reply-To: <20041018142524.5b81a09a.akpm@osdl.org>

On Mon, 2004-10-18 at 16:25, Andrew Morton wrote:
> James Bottomley <James.Bottomley@SteelEye.com> wrote:
> >
> > I'm in the process of moving some of our scsi timers which do more work
> > than just a few lines of code into schedule_work() instead.  The problem
> > is that the workqueue API lacks the equivalent of del_timer_sync(). 
> 
> The usual way of doing this is:
> 
> 	cancel_delayed_work(...);

That API doesn't seem to be in the vanilla kernel ... is it mm only?

> 	flush_workqueue(...);

Yes, but the flush_workqueue() has you waiting until every piece of work
on the workqueue has completed ... that creates an unacceptable delay in
the routine that wants it either cancelled or run.

James




  reply	other threads:[~2004-10-18 21:29 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-10-18 16:31 [PATCH] add unschedule_delayed_work to the workqueue API James Bottomley
2004-10-18 21:25 ` Andrew Morton
2004-10-18 21:26   ` James Bottomley [this message]
2004-10-18 21:29     ` James Bottomley
2004-10-18 21:43       ` Andrew Morton
2004-10-18 21:47         ` James Bottomley
2004-10-18 22:02           ` Andrew Morton
2004-10-18 22:15             ` James Bottomley
2004-10-18 22:57               ` Andrew Morton
2004-10-18 23:24                 ` James Bottomley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1098134824.2011.322.camel@mulgrave \
    --to=james.bottomley@steeleye.com \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox