From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: Linux Kernel list <linux-kernel@vger.kernel.org>,
linuxppc64-dev <linuxppc64-dev@ozlabs.org>,
Linus Torvalds <torvalds@osdl.org>,
Paul Mackerras <paulus@samba.org>,
Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH] generic irq subsystem: ppc64 port
Date: Wed, 20 Oct 2004 11:24:59 +1000 [thread overview]
Message-ID: <1098235499.22943.16.camel@gaston> (raw)
In-Reply-To: <20041019091557.GA17473@elte.hu>
On Tue, 2004-10-19 at 19:15, Ingo Molnar wrote:
> * Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
>
> > I still like the idea of the patch, so it would be useful if you added
> > the possibility for us to just change that behaviour, that is replace
> > all occursences of irq_descs + i with get_irq_desc() and provide a
> > generic one that just does that, with a #ifndef so that the
> > architecture can provide it's own.
>
> sure, we could do that. But since there are other architectures with
> large irq-vector spaces too, you might want to try to move it into the
> generic IRQ code and just provide a way to switch between 1:1 mapped and
> sparse-mapped variants.
False alert ! In fact, Paulus rewrote that stuff a while ago and I
totally forgot about it. We no longer do that, our get_irq_desc()
is nowadays just doing (&irq_desc[(irq)]). We map the large
physical interrupt numbers to "virtual" numbers that are the only
thing the generic code sees, so it's fine.
Ben.
prev parent reply other threads:[~2004-10-20 1:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200410190714.i9J7Elnx027734@hera.kernel.org>
2004-10-19 8:28 ` [PATCH] generic irq subsystem: ppc64 port Benjamin Herrenschmidt
2004-10-19 8:41 ` Christoph Hellwig
2004-10-19 9:15 ` Ingo Molnar
2004-10-20 1:24 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1098235499.22943.16.camel@gaston \
--to=benh@kernel.crashing.org \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc64-dev@ozlabs.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox