From: Rusty Russell <rusty@rustcorp.com.au>
To: Andrew Morton <akpm@osdl.org>
Cc: lkml - Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: [PATCH 1/2] MODULE_PARM must die: make it warn first.
Date: Wed, 20 Oct 2004 17:42:53 +1000 [thread overview]
Message-ID: <1098258172.10571.143.camel@localhost.localdomain> (raw)
Name: Warn on use of MODULE_PARM
Status: Trivial
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
This patch adds a warning whenever MODULE_PARM is used. Successive
patches change them over to module_param. Help appreciated!
diff -urpN --exclude TAGS -X /home/rusty/devel/kernel/kernel-patches/current-dontdiff --minimal .22800-linux-2.6-bk/include/linux/module.h .22800-linux-2.6-bk.updated/include/linux/module.h
--- .22800-linux-2.6-bk/include/linux/module.h 2004-10-20 15:15:30.000000000 +1000
+++ .22800-linux-2.6-bk.updated/include/linux/module.h 2004-10-20 17:11:39.000000000 +1000
@@ -562,13 +562,15 @@ struct obsolete_modparm {
char type[64-sizeof(void *)];
void *addr;
};
+
+extern void __deprecated MODULE_PARM_(void);
#ifdef MODULE
/* DEPRECATED: Do not use. */
#define MODULE_PARM(var,type) \
struct obsolete_modparm __parm_##var __attribute__((section("__obsparm"))) = \
-{ __stringify(var), type };
+{ __stringify(var), type, &MODULE_PARM_ };
#else
-#define MODULE_PARM(var,type)
+#define MODULE_PARM(var,type) static void __attribute_unused__ *__parm_##var = &MODULE_PARM_;
#endif
#define __MODULE_STRING(x) __stringify(x)
--
Anyone who quotes me in their signature is an idiot -- Rusty Russell
reply other threads:[~2004-10-20 8:03 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1098258172.10571.143.camel@localhost.localdomain \
--to=rusty@rustcorp.com.au \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox