public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Dave Ahlswede <mightyquinn@charter.net>
To: linux-kernel@vger.kernel.org
Cc: vojtech@suse.cz
Subject: [PATCH] Make kbtab play nice with wacom_drv in Xorg/XFree86
Date: Wed, 20 Oct 2004 07:27:21 -0400	[thread overview]
Message-ID: <1098271641.26932.12.camel@sayuki> (raw)

In its current state, the kbtab driver can be made to work with the
XF86/Xorg Wacom driver, but only once per modprobe. If X is restarted,
the driver won't report any input events. This is because the driver
always reports the pen tool as being in use, and the information doesn't
seem to be passed after the first time the device is opened.

This patch fixes the issue by causing the driver to briefly report the
pen not in use each time the device is opened. 

Also, while the specs say the tablet is supposed to have 256 levels of
pressure sensitivity, it only seems to report 0-127 on both tablets that
I have access to. This patch changes the reported bounds to cooperate
better with Gimp 2.1.

To actually use this in X, it may require the latest stable driver from
http://linuxwacom.sourceforge.net
--Dave Ahlswede

(Please CC me personally with any replies, as I'm not subscribed to the
list-- thanks!)

Patch follows:
--- linux-2.6.7-orig/drivers/usb/input/kbtab.c	2004-06-16 01:18:38 -0400
+++ linux-2.6.7-da1/drivers/usb/input/kbtab.c	2004-08-08 11:08:00 -0400
@@ -13,6 +13,9 @@
  * v0.0.2 - Updated, works with 2.5.62 and 2.4.20;
  *           - added pressure-threshold modules param code from
  *              Alex Perry <alex.perry@ieee.org>
+ *           - fixed so driver always reports the pen tool in use
+ *              after first device open, and max pressure limit(?)
+ *              Dave Ahlswede <mightyquinn@letterboxes.org>
  */
 
 #define DRIVER_VERSION "v0.0.2"
@@ -105,9 +108,10 @@
 {
 	struct kbtab *kbtab = dev->private;
 
-	if (kbtab->open++)
+	if (kbtab->open++) {
+		input_report_key(dev, BTN_TOOL_PEN, 0);
 		return 0;
-
+	}
 	kbtab->irq->dev = kbtab->usbdev;
 	if (usb_submit_urb(kbtab->irq, GFP_KERNEL)) {
 		kbtab->open--;
@@ -160,7 +164,7 @@
 
 	kbtab->dev.absmax[ABS_X] = 0x2000;
 	kbtab->dev.absmax[ABS_Y] = 0x1750;
-	kbtab->dev.absmax[ABS_PRESSURE] = 0xff;
+	kbtab->dev.absmax[ABS_PRESSURE] = 0x7F;
 	
 	kbtab->dev.absfuzz[ABS_X] = 4;
 	kbtab->dev.absfuzz[ABS_Y] = 4;



             reply	other threads:[~2004-10-20 11:28 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-10-20 11:27 Dave Ahlswede [this message]
2004-10-20 13:04 ` [PATCH] Make kbtab play nice with wacom_drv in Xorg/XFree86 Vojtech Pavlik
2004-10-20 15:55   ` Dave Ahlswede

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1098271641.26932.12.camel@sayuki \
    --to=mightyquinn@charter.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mightyquinn@letterboxes.org \
    --cc=vojtech@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox