From: Paul Fulghum <paulkf@microgate.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Russell King <rmk+lkml@arm.linux.org.uk>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"Martin J. Bligh" <mbligh@aracnet.com>,
Linus Torvalds <torvalds@osdl.org>, Alan Cox <alan@redhat.com>
Subject: Re: Fwd: [Bug 3592] New: pppd "IPCP: timeout sending Config-Requests"
Date: Wed, 20 Oct 2004 18:42:40 -0500 [thread overview]
Message-ID: <1098315760.6006.13.camel@at2.pipehead.org> (raw)
In-Reply-To: <1098309449.12411.57.camel@localhost.localdomain>
On Wed, 2004-10-20 at 16:57, Alan Cox wrote:
> On Maw, 2004-10-19 at 16:32, Paul Fulghum wrote:
> > PPP line disciplines rely on the previous behavior
> > of calling ldisc->close on hangup as a method for
> > indicating hangup to the line discipline.
> > This is explicitly called out in the PPP ldisc comments.
>
> I had no choice about that really with the current locking. It's on the
> list to do further work although I'd not realised some odder pppd
> configurations relied upon it until the bug report.
OK
I'm not sure I would characterize using DCD
for a serial connection indicator as odd.
> Once I've put out -ac1 to fix the other bugs I consider urgent (not tty)
> I'll see what I can do. Really it would nice if the ppp maintainer would
> look at this and also fix all the horrible things the code does wrongly
> if for example the first byte of a received buffer is an error marker -
> in general serial error processing is not robust in the ppp code it
> appears.
I'll look at what is needed to implement the
new ldisc->hangup() method for the PPP line disciplines.
--
Paul Fulghum
paulkf@microgate.com
next prev parent reply other threads:[~2004-10-21 1:00 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-19 12:12 Fwd: [Bug 3592] New: pppd "IPCP: timeout sending Config-Requests" Russell King
2004-10-19 14:17 ` Paul Fulghum
2004-10-19 15:32 ` Paul Fulghum
2004-10-20 21:57 ` Alan Cox
2004-10-20 23:42 ` Paul Fulghum [this message]
2004-10-20 23:46 ` Alan Cox
2004-10-21 0:00 ` Paul Fulghum
2004-11-20 13:11 ` Russell King
2004-11-20 12:34 ` Alan Cox
2004-11-20 14:21 ` Russell King
2004-11-20 15:09 ` Paul Fulghum
2004-11-20 16:57 ` Russell King
2004-11-20 18:48 ` Paul Fulghum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1098315760.6006.13.camel@at2.pipehead.org \
--to=paulkf@microgate.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=alan@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mbligh@aracnet.com \
--cc=rmk+lkml@arm.linux.org.uk \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox