Re: Linux 2.6.9-ac2

Marcelo Tosatti
2004-10-28T17:41:24Z

On Thu, Oct 21, 2004 at 09:12:08PM +0100, Alan Cox wrote:
> On Iau, 2004-10-21 at 20:34, David S. Miller wrote:
> > 2.4.x will need this one as well, at least the AF_PACKET
> > case. Would you mind if I pushed that to Marcelo?
>
> Not at all. Andrea has proposed fixing it a little differently.
> For 2.6 making remap_page_range DTRT itself is ok but for 2.4 the
> vma isn't passed.

get_user_pages() is screwed, I'm just not sure
about failing get_user_pages() if PageReserved page
is encountered.

I'm more worried about make_pages_present(), which is
called by find_extend_vma/do_mmap_pgoff. Is it valid
to have PageReserved pages on the zones handled
by these functions anyway?

This is equivalent of Andrea's fix for mainline.

Andrea, this in SuSE's tree for a while correct?

--- memory.c 2004-10-22 15:58:28.000000000 -0200
+++ memory.c 2004-10-28 14:32:26.585813200 -0200
@@ -499,7 +499,7 @@
/* FIXME: call the correct function,
* depending on the type of the found page
*/
- if (!pages[i])
+ if (!pages[i] || PageReserved(pages[i]))
goto bad_page;
page_cache_get(pages[i]);
}