Re: [PATCH] Completion API extension

[Thomas Gleixner <tglx@linutronix.de>]

On Fri, 2004-10-22 at 04:18, Dmitry Torokhov wrote:

Hi,

it's resubmitted in a correct version already.

Thanks,

tglx


> Hi,
> 
> On Wednesday 20 October 2004 11:31 am, Thomas Gleixner wrote:
> > +unsigned long fastcall __sched
> > +wait_for_completion_interruptible_timeout(struct completion *x,
> > +                                         unsigned long timeout)
> > +{
> > +       might_sleep();
> > +
> > +       spin_lock_irq(&x->wait.lock);
> > +       if (!x->done) {
> > +               DECLARE_WAITQUEUE(wait, current);
> > +
> > +               wait.flags |= WQ_FLAG_EXCLUSIVE;
> > +               __add_wait_queue_tail(&x->wait, &wait);
> > +               do {
> > +                       if (signal_pending(current)) {
> > +                               timeout = -ERESTARTSYS;
> > +                               goto out;
> > +                       }
> > +                       __set_current_state(TASK_INTERRUPTIBLE);
> > +                       spin_unlock_irq(&x->wait.lock);
> > +                       schedule();
> 
> 			^^^^^^^^^^^^^^^^^^
> 
> schedule_timeout perhaps?
>