From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Nishanth Aravamudan <nacc@us.ibm.com>
Cc: Paul Mackerras <paulus@samba.org>, Andrew Morton <akpm@osdl.org>,
Linus Torvalds <torvalds@osdl.org>,
Linux Kernel list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] PPC32: Fix cpu voltage change delay
Date: Sat, 23 Oct 2004 08:34:24 +1000 [thread overview]
Message-ID: <1098484464.11740.77.camel@gaston> (raw)
In-Reply-To: <20041022180117.GA2162@us.ibm.com>
On Sat, 2004-10-23 at 04:01, Nishanth Aravamudan wrote:
> While looking through the latest bk changelogs, I noticed that you had
> submitted this patch using msleep(). When I read the comment, though,
> that you were offsetting the 1 millisecond with a jiffy, I was slightly
> confused as msleep() is designed to sleep for *at least* the time
> requested. So if you just use msleep(1) in these cases, you should have
> the desired effect. msleep() is designed to be independent of HZ (as the
> timeout is specified in non-jiffy units). Not using the
> jiffies_to_msecs() macro would remove some extra instructions... The
> attached patch makes this change (on top of your patch currently in bk7)
> and also changes the other schedule_timeout()s (at least, those that can
> be) to msleep.
No, please leave them as-is at least for now... Last we saw, there was
a potential issue with schedule_timeout(1) itself not guaranteeing it would
sleep for an entire jiffie, but only up to the next jiffie...
Ben.
next prev parent reply other threads:[~2004-10-22 22:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-10 3:49 [PATCH] PPC32: Fix cpu voltage change delay Paul Mackerras
2004-10-22 18:01 ` Nishanth Aravamudan
2004-10-22 22:34 ` Benjamin Herrenschmidt [this message]
2004-10-22 22:49 ` Nishanth Aravamudan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1098484464.11740.77.camel@gaston \
--to=benh@kernel.crashing.org \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nacc@us.ibm.com \
--cc=paulus@samba.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).