public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Nigel Cunningham <ncunningham@linuxmail.org>
To: Pavel Machek <pavel@ucw.cz>
Cc: Patrick Mochel <mochel@digitalimplant.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Fixing MTRR smp breakage and suspending sysdevs.
Date: Tue, 26 Oct 2004 12:39:14 +1000	[thread overview]
Message-ID: <1098758354.4120.7.camel@desktop.cunninghams> (raw)

Hi!

I've just had a go at fixing the issue with my implementation not
suspending the sysdevs (I believe swsusp does the same). In the process,
I reworked the MTRR support so it's not treated as a sysdev. Instead,
when we're saving cpu state, the mtrr_save function function is called.
When we go to restore CPU state, each CPU calls a function that resets
it's MTRRs and the 'main' cpu then frees the saved data. This is working
well here (did a dozen plus suspends on the trot), but I want to check
that it sounds like the right solution to you.

Perhaps this method should be made more generic? (Are there likely to be
other per-cpu state savers needed?)

One thing I have noticed is that by adding the sysdev suspend/resume
calls, I've gained a few seconds delay. I'll see if I can track down the
cause.

Regards,

Nigel
-- 
Nigel Cunningham
Pastoral Worker
Christian Reformed Church of Tuggeranong
PO Box 1004, Tuggeranong, ACT 2901

Everyone lives by faith. Some people just don't believe it.
Want proof? Try to prove that the theory of evolution is true.


             reply	other threads:[~2004-10-26  2:57 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-10-26  2:39 Nigel Cunningham [this message]
  -- strict thread matches above, loose matches on Subject: below --
2004-10-27  2:48 Fixing MTRR smp breakage and suspending sysdevs Li, Shaohua
2004-10-27  2:49 ` Nigel Cunningham
2004-10-27  3:20 ` Dmitry Torokhov
2004-10-27  3:17   ` Nigel Cunningham
2004-10-27  3:50     ` Dmitry Torokhov
2004-10-27  3:55       ` Nigel Cunningham
2004-10-27 10:00 ` Pavel Machek
2004-10-27 12:23 Li, Shaohua
2004-10-28 10:20 ` Pavel Machek
2004-10-28  1:54 Pallipadi, Venkatesh
2004-10-28  9:00 ` Pavel Machek
2004-10-28  2:40 Li, Shaohua
2004-10-29  1:41 Li, Shaohua

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1098758354.4120.7.camel@desktop.cunninghams \
    --to=ncunningham@linuxmail.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mochel@digitalimplant.org \
    --cc=pavel@ucw.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox