public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Nigel Cunningham <ncunningham@linuxmail.org>
To: Dmitry Torokhov <dtor_core@ameritech.net>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	"Li, Shaohua" <shaohua.li@intel.com>, Pavel Machek <pavel@ucw.cz>,
	Patrick Mochel <mochel@digitalimplant.org>
Subject: Re: Fixing MTRR smp breakage and suspending sysdevs.
Date: Wed, 27 Oct 2004 13:55:33 +1000	[thread overview]
Message-ID: <1098849333.6269.8.camel@desktop.cunninghams> (raw)
In-Reply-To: <200410262250.40674.dtor_core@ameritech.net>

Hi.

On Wed, 2004-10-27 at 13:50, Dmitry Torokhov wrote:
> Well, I understand that ACPI is using semaphore and a GFP_KERNEL, but what
> is the problem with MTRR? I understand that they should be set with IRQ
> off but I highly doibt that enabling IRQ at the end is a requirement.
> I think what is described in the commnet is rather a "normal flow of events".

The real problem with MTRRs is SMP support: smp_call_function doesn't
like IRQs disabled.

I got around a similar issue with saving CPU state (for suspend-to-disk)
by using the same general sequence that I later discovered described in
arch/i386/kernel/cpu/mtrr/main.c (set_mtrr header) for saving CPU
contexts. I extended it yesterday to do the MTRR settings as well,
before Shaohua pointed to the more general need.

Regards,

Nigel
-- 
Nigel Cunningham
Pastoral Worker
Christian Reformed Church of Tuggeranong
PO Box 1004, Tuggeranong, ACT 2901

Everyone lives by faith. Some people just don't believe it.
Want proof? Try to prove that the theory of evolution is true.


  reply	other threads:[~2004-10-27  4:04 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-10-27  2:48 Fixing MTRR smp breakage and suspending sysdevs Li, Shaohua
2004-10-27  2:49 ` Nigel Cunningham
2004-10-27  3:20 ` Dmitry Torokhov
2004-10-27  3:17   ` Nigel Cunningham
2004-10-27  3:50     ` Dmitry Torokhov
2004-10-27  3:55       ` Nigel Cunningham [this message]
2004-10-27 10:00 ` Pavel Machek
2004-10-28 22:38   ` time and suspending sysdevs [was Re: Fixing MTRR smp breakage and suspending sysdevs.] Pavel Machek
2004-10-29  0:18     ` Nigel Cunningham
  -- strict thread matches above, loose matches on Subject: below --
2004-10-29  1:41 Fixing MTRR smp breakage and suspending sysdevs Li, Shaohua
2004-10-28  2:40 Li, Shaohua
2004-10-28  1:54 Pallipadi, Venkatesh
2004-10-28  9:00 ` Pavel Machek
2004-10-27 12:23 Li, Shaohua
2004-10-28 10:20 ` Pavel Machek
2004-10-26  2:39 Nigel Cunningham

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1098849333.6269.8.camel@desktop.cunninghams \
    --to=ncunningham@linuxmail.org \
    --cc=dtor_core@ameritech.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mochel@digitalimplant.org \
    --cc=pavel@ucw.cz \
    --cc=shaohua.li@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox