public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Germano <germano.barreiro@cyclades.com>
To: "Kilau, Scott" <Scott_Kilau@digi.com>
Cc: Greg KH <greg@kroah.com>, Roland Dreier <roland@topspin.com>,
	Marcelo Tosatti <marcelo.tosatti@cyclades.com>,
	linux-kernel@vger.kernel.org
Subject: RE: patch for sysfs in the cyclades driver
Date: Thu, 04 Nov 2004 16:28:13 -0200	[thread overview]
Message-ID: <1099592893.2161.6.camel@tsthost> (raw)
In-Reply-To: <71A17D6448EC0140B44BCEB8CD0DA36E041BF5BC@minimail.digi.com>

I send my thanks to all too. Finally (I hope no new problems appear) the
exit of the maze :)


Em Qui, 2004-11-04 às 15:50, Kilau, Scott escreveu:
> > > and the implementation in in drivers/scsi/st.c, that there's no
> > > problem adding attributes to a device in a simple class.  You can
> just
> > > use class_set_devdata() on your class_device to set whatever context
> > > you need to get back to your internal structures, and then use
> > > class_device_create_file() to add the attributes.
> > > 
> > > I assume this is OK (since there is already one in-kernel driver
> doing
> > > it), but Greg, can you confirm that it's definitely OK for a driver
> to
> > > use class_set_devdata() on a class_device from
> class_simple_device_add()?
> 
> > Hm, I think that should be ok, but I'd make sure to test it before
> > verifying that it really is :)
> 
> I have just added this code and tested it, and indeed it *does* work!
> 
> So I will graciously redraw my comments from my previous email.
> It works, and this is definitely the way Germano and I should go in
> each of our respective drivers.
> 
> Thanks again for everyones comments/help!
> 
> Scott Kilau
> Digi International
> 


  reply	other threads:[~2004-11-04 18:17 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-11-04 17:50 patch for sysfs in the cyclades driver Kilau, Scott
2004-11-04 18:28 ` Germano [this message]
  -- strict thread matches above, loose matches on Subject: below --
2004-11-04 16:40 Kilau, Scott
2004-11-04 17:39 ` Greg KH
2004-11-03 22:35 Kilau, Scott
2004-11-03 23:08 ` Greg KH
2004-11-03 20:20 Kilau, Scott
2004-11-03 21:23 ` Greg KH
2004-11-03 19:55 Kilau, Scott
2004-11-03 20:03 ` Greg KH
2004-11-03 13:09 Germano
2004-11-04 10:25 ` Marcelo Tosatti
2004-11-04 16:58   ` Roland Dreier
2004-11-04 14:29     ` Marcelo Tosatti
2004-11-04 17:40       ` Roland Dreier
2004-11-04 17:44         ` Greg KH
2004-11-04 17:42       ` Greg KH
2004-11-04 17:40     ` Greg KH
2004-11-04 19:05       ` Roland Dreier
2004-11-04 19:17         ` Greg KH
     [not found] <71A17D6448EC0140B44BCEB8CD0DA36E04B9D812@minimail.digi.com>
2004-11-03  2:28 ` Greg KH
2004-10-28 18:56 Germano Barreiro
2004-10-30  4:40 ` Greg KH
2004-11-01 17:01   ` germano.barreiro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1099592893.2161.6.camel@tsthost \
    --to=germano.barreiro@cyclades.com \
    --cc=Scott_Kilau@digi.com \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcelo.tosatti@cyclades.com \
    --cc=roland@topspin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox